Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add integration test for universe domain #7713

Merged
merged 5 commits into from
Sep 30, 2024
Merged

feat(storage): add integration test for universe domain #7713

merged 5 commits into from
Sep 30, 2024

Conversation

thiyaguk09
Copy link
Contributor

Adding integration tests for Universe Domain feature
these tests will run with test project credentials

@thiyaguk09 thiyaguk09 requested review from a team as code owners September 30, 2024 10:04
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 30, 2024
bshaffer
bshaffer approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! but, I can't push my recommended changes (see 6f054e4). Next time please give admins access to push changes to your PR branch, so this doesn't require a second PR.

Merging for now, I'll instead add the changes to #7717

@bshaffer bshaffer merged commit b5642e6 into googleapis:main Sep 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiyaguk09 @bshaffer