fix and rename tests again

googleapis · Sep 27, 2024 · fa97870 · fa97870
1 parent da55557
commit fa97870
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 13 deletions.
diff --git a/.github/workflows/backwards-compatibility-checks.yaml b/.github/workflows/backwards-compatibility-checks.yaml
@@ -1,4 +1,4 @@
-name: Backward Compatibility
+name: Backwards Compatibility
 on:
   pull_request:
     types: [opened, synchronize, reopened, edited]
@@ -121,4 +121,4 @@ jobs:
             echo "Add \"MAJOR_VERSION_ALLOWED=component1,component2\" to the PR description to allow "
             echo "major version releases for those components"
             exit 1
-          fi
+          fi
diff --git a/...s/emulator-conformance-tests-storage.yaml → ...s/conformance-tests-storage-emulator.yaml b/...s/emulator-conformance-tests-storage.yaml → ...s/conformance-tests-storage-emulator.yaml
diff --git a/...flows/emulator-system-tests-bigtable.yaml → ...flows/system-tests-bigtable-emulator.yaml b/...flows/emulator-system-tests-bigtable.yaml → ...flows/system-tests-bigtable-emulator.yaml
@@ -4,12 +4,12 @@ on:
       - main
     paths:
       - 'Bigtable/**'
-      - '.github/workflows/emulator-system-tests-bigtable.yaml'
+      - '.github/workflows/system-tests-bigtable-emulator.yaml'
       - '.github/emulator/**'
   pull_request:
     paths:
       - 'Bigtable/**'
-      - '.github/workflows/emulator-system-tests-bigtable.yaml'
+      - '.github/workflows/system-tests-bigtable-emulator.yaml'
       - '.github/emulator/**'
 name: Run Bigtable System Tests With Emulator
 permissions:

diff --git a/...lows/emulator-system-tests-datastore.yaml → ...lows/system-tests-datastore-emulator.yaml b/...lows/emulator-system-tests-datastore.yaml → ...lows/system-tests-datastore-emulator.yaml
@@ -5,12 +5,12 @@ on:
       - main
     paths:
       - 'Datastore/**'
-      - '.github/workflows/emulator-system-tests-datastore.yaml'
+      - '.github/workflows/system-tests-datastore-emulator.yaml'
       - '.github/emulator/**'
   pull_request:
     paths:
       - 'Datastore/**'
-      - '.github/workflows/emulator-system-tests-datastore.yaml'
+      - '.github/workflows/system-tests-datastore-emulator.yaml'
       - '.github/emulator/**'
 permissions:
   contents: read

diff --git a/...lows/emulator-system-tests-firestore.yaml → ...lows/system-tests-firestore-emulator.yaml b/...lows/emulator-system-tests-firestore.yaml → ...lows/system-tests-firestore-emulator.yaml
@@ -4,12 +4,12 @@ on:
       - main
     paths:
       - 'Firestore/**'
-      - '.github/workflows/emulator-system-tests-firestore.yaml'
+      - '.github/workflows/system-tests-firestore-emulator.yaml'
       - '.github/emulator/**'
   pull_request:
     paths:
       - 'Firestore/**'
-      - '.github/workflows/emulator-system-tests-firestore.yaml'
+      - '.github/workflows/system-tests-firestore-emulator.yaml'
       - '.github/emulator/**'
 name: Run Firestore System Tests With Emulator
 permissions:

diff --git a/...rkflows/emulator-system-tests-pubsub.yaml → ...rkflows/system-tests-pubsub-emulator.yaml b/...rkflows/emulator-system-tests-pubsub.yaml → ...rkflows/system-tests-pubsub-emulator.yaml
@@ -4,12 +4,12 @@ on:
       - main
     paths:
       - 'PubSub/**'
-      - '.github/workflows/emulator-system-tests-pubsub.yaml'
+      - '.github/workflows/system-tests-pubsub-emulator.yaml'
       - '.github/emulator/**'
   pull_request:
     paths:
       - 'PubSub/**'
-      - '.github/workflows/emulator-system-tests-pubsub.yaml'
+      - '.github/workflows/system-tests-pubsub-emulator.yaml'
       - '.github/emulator/**'
 name: Run PubSub System Tests With Emulator
 permissions:

diff --git a/...kflows/emulator-system-tests-spanner.yaml → ...kflows/system-tests-spanner-emulator.yaml b/...kflows/emulator-system-tests-spanner.yaml → ...kflows/system-tests-spanner-emulator.yaml
@@ -4,11 +4,11 @@ on:
       - main
     paths:
       - 'Spanner/**'
-      - '.github/workflows/emulator-system-tests-spanner.yaml'
+      - '.github/workflows/system-tests-spanner-emulator.yaml'
   pull_request:
     paths:
       - 'Spanner/**'
-      - '.github/workflows/emulator-system-tests-spanner.yaml'
+      - '.github/workflows/system-tests-spanner-emulator.yaml'
 name: Run Spanner System Tests With Emulator
 permissions:
   contents: read

diff --git a/.github/workflows/tests.yaml → .github/workflows/unit-tests.yaml b/.github/workflows/tests.yaml → .github/workflows/unit-tests.yaml
diff --git a/Redis/tests/System/V1/CloudRedisClientTest.php b/Redis/tests/System/V1/CloudRedisClientTest.php
@@ -105,9 +105,10 @@ public function testDeleteOperation()
         $this->assertTrue($deleteOp->operationSucceeded());
 
         // Ensure delete op succeeded
+        $instances = self::$client->listInstances(ListInstancesRequest::build(self::$parent));
         $this->assertSame(0, count(array_map(
             fn ($instance) => $instance->getName() === $instanceName,
-            iterator_to_array($client->listInstances($listInstancesRequest)->iterateAllElements())
+            iterator_to_array($instances->iterateAllElements())
         )));
     }
 }