Skip to content

Commit

Permalink
Addressed the review comments.
Browse files Browse the repository at this point in the history
Addressed the review comments.
  • Loading branch information
thiyaguk09 committed Dec 30, 2024
1 parent 6132612 commit c728cd8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Storage/src/StorageClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ function (array $bucket) use ($userProject) {
* }
* @return Bucket
*/
public function restore($name, $generation, array $options = [])
public function restore(string $name, string $generation, array $options = [])
{
$res = $this->connection->restoreBucket([
'bucket' => $name,
Expand Down
4 changes: 2 additions & 2 deletions Storage/tests/Unit/StorageClientTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ public function testGetSoftDeletedBucket()

public function testGetsSoftDeletedBuckets()
{
$this->connection->listBuckets(Argument::allOf(
$this->connection->listBuckets(
Argument::withEntry('softDeleted', true)
))->willReturn([
)->willReturn([
'items' => [
['name' => 'bucket1']
]
Expand Down

0 comments on commit c728cd8

Please sign in to comment.