Skip to content

Commit

Permalink
chore!: promote AnalyticsData to v2
Browse files Browse the repository at this point in the history
  • Loading branch information
bshaffer committed Dec 17, 2024
1 parent 70dd30d commit 750ebf7
Show file tree
Hide file tree
Showing 177 changed files with 730 additions and 11,580 deletions.
2 changes: 1 addition & 1 deletion .repo-metadata-full.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"AnalyticsData": {
"language": "php",
"distribution_name": "google/analytics-data",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/analytics-data/latest",
"library_type": "GAPIC_AUTO",
"api_shortname": "analyticsdata"
Expand Down
2 changes: 1 addition & 1 deletion AnalyticsData/.OwlBot.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
deep-copy-regex:
- source: /google/analytics/data/(v1alpha|v1beta)/.*-php/(.*)
- source: /google/analytics/data/(v1beta|v1alpha)/.*-php/(.*)
dest: /owl-bot-staging/AnalyticsData/$1/$2
api-name: AnalyticsData
5 changes: 2 additions & 3 deletions AnalyticsData/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,8 @@ for more information about the debugging tools.

### Version

This component is considered beta. As such, it should be expected to be mostly
stable and we're working towards a release candidate. We will address issues
and requests with a higher priority.
This component is considered GA (generally available). As such, it will not introduce backwards-incompatible changes in
any minor or patch releases. We will address issues and requests with the highest priority.

### Next Steps

Expand Down
41 changes: 4 additions & 37 deletions AnalyticsData/owlbot.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2020 Google LLC
# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -30,13 +30,7 @@
# Added so that we can pass copy_excludes in the owlbot_main() call
_tracked_paths.add(src)

php.owlbot_main(
src=src,
dest=dest,
copy_excludes=[
src / "**/[A-Z]*_*.php"
]
)
php.owlbot_main(src=src, dest=dest)

# remove class_alias code
s.replace(
Expand All @@ -47,33 +41,6 @@
+ "\n",
'')


### [START] protoc backwards compatibility fixes

# roll back to private properties.
s.replace(
"src/**/V*/**/*.php",
r"Generated from protobuf field ([^\n]{0,})\n\s{5}\*/\n\s{4}protected \$",
r"""Generated from protobuf field \1
*/
private $""")

# Replace "Unwrapped" with "Value" for method names.
s.replace(
"src/**/V*/**/*.php",
r"public function ([s|g]\w{3,})Unwrapped",
r"public function \1Value"
)

### [END] protoc backwards compatibility fixes

# fix relative cloud.google.com links
s.replace(
"src/**/V*/**/*.php",
r"(.{0,})\]\((/.{0,})\)",
r"\1](https://cloud.google.com\2)"
)

# format generated clients
subprocess.run([
'npm',
Expand All @@ -82,8 +49,8 @@
'--package=@prettier/plugin-php@^0.16',
'--',
'prettier',
'**/Gapic/*',
'**/Client/*',
'--write',
'--parser=php',
'--single-quote',
'--print-width=80'])
'--print-width=120'])
36 changes: 0 additions & 36 deletions AnalyticsData/src/V1alpha/AlphaAnalyticsDataClient.php

This file was deleted.

148 changes: 0 additions & 148 deletions AnalyticsData/src/V1alpha/AlphaAnalyticsDataGrpcClient.php

This file was deleted.

2 changes: 1 addition & 1 deletion AnalyticsData/src/V1alpha/AudienceDimension.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions AnalyticsData/src/V1alpha/AudienceList.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 750ebf7

Please sign in to comment.