feat: add fields with proto3_optional #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upgrade protoc version to v3.12.0-rc-2
alexander-fenster
approved these changes
May 15, 2020
|
re: TypeScript build failure - it requires googleapis/gapic-generator-typescript#460 that I will merge within a day or two. |
chrisdunelm
approved these changes
May 15, 2020
* gapic-generator-kotlin is unmaintained and the work to support proto3_optional is unplanned * go-smoke-test is unnecessary because gapic-generator-go is used in the compile_protos step to regenerate the client and CLI on every PR
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
- Coverage 99.61% 99.42% -0.19%
==========================================
Files 13 13
Lines 1036 1048 +12
==========================================
+ Hits 1032 1042 +10
- Misses 2 3 +1
- Partials 2 3 +1
Continue to review full report at Codecov.
|
This was referenced May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds several primitive fields to
google.showcase.v1.Userthat are marked withproto3_optional. Adds amethod_signaturewith all of theproto3_optionalfields.Upgrades protoc version to v3.12.0-rc-2 in ci.
Chore: elide struct type name in slices in identity_service_test.go to remove linter warnings
Chore: disable
kotlin-smoke-testjob, it is not maintained and doesn't supportproto3_optionalChore: remove
go-smoke-testjob because it's redundant, gapic-generator-go is run in thecompile_protosjobChore: disable
python-smoke-testandtypescript-smoke-testjobs until they supportproto3_optional, tracked by #382 and #383 respectivelyNote: PR includes regenerated protobuf/gRPC API and CLI (no changes in Go GAPIC).
cc: @AlanGasperini @hkdevandla