Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: paging changes for bigquery #1661

Merged
merged 38 commits into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
f84de82
debug statements
leahecole Sep 17, 2024
bdd1bc6
WIP pagination
leahecole Sep 23, 2024
e12ea0e
WIP
leahecole Sep 26, 2024
f214edd
WIP - partial pagination work
leahecole Sep 26, 2024
04debcf
WIP - pageResponseType compiles
leahecole Sep 30, 2024
96e41d3
WIP
leahecole Oct 8, 2024
3b1e72e
WIP success pagination maxResults
leahecole Oct 15, 2024
b053125
partial cleanup
leahecole Oct 15, 2024
d004344
remove unnecessary step
leahecole Oct 15, 2024
d9cc58e
WIP - some tempalte changes
leahecole Oct 18, 2024
55da34f
more changes
leahecole Oct 22, 2024
ff5d595
lint
leahecole Oct 22, 2024
6ea1138
update baselines
leahecole Oct 22, 2024
054087e
run baselines
leahecole Oct 23, 2024
d95c704
update esm templates
leahecole Oct 23, 2024
62b7d3d
add bq cjs baseline
leahecole Oct 23, 2024
7801deb
add bigquery esm baselines
leahecole Oct 23, 2024
360a9f0
change package.json baseline to symlink
leahecole Oct 23, 2024
4bf18f2
change esm package.json baseline to symlink
leahecole Oct 23, 2024
9e5ddda
add bq to ci.yml
leahecole Nov 1, 2024
3bfbf8a
add debug line
leahecole Nov 1, 2024
db2b464
more debugging
leahecole Nov 1, 2024
9a54117
remove debug
leahecole Nov 1, 2024
0d53d4c
WIP: baselines
leahecole Nov 4, 2024
2b499ad
update baselines
leahecole Nov 4, 2024
5c374fe
add bq protos
leahecole Nov 5, 2024
6e96382
run baseline job
leahecole Nov 6, 2024
5573fdf
run baseline job
leahecole Nov 6, 2024
8af9d2f
Merge branch 'paging_changes' of github.com:googleapis/gapic-generato…
leahecole Nov 6, 2024
2fb75fd
add reviewer suggestion to protos.ts, update baselines
leahecole Nov 6, 2024
d0851e8
make the maxResultsParameter undefined for all APIS that aren't BQ
leahecole Nov 6, 2024
fab2dcf
update samples comments
leahecole Nov 7, 2024
ba2d288
fix lint
leahecole Nov 7, 2024
43b3d04
remove todo
leahecole Nov 7, 2024
28eb70f
remove todo
leahecole Nov 7, 2024
ee00fbc
address reviewer suggestions
leahecole Nov 8, 2024
9784109
address reviewer suggestion
leahecole Nov 8, 2024
24cbc2e
fix lint
leahecole Nov 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions baselines/bigquery-v2-esm/.babelrc.json.baseline
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"presets": [
"@babel/preset-typescript",
"@babel/env"
],
"plugins": [
[
"replace-import-extension",
{
"extMapping": {
".js": ".cjs"
}
}
],
"./node_modules/gapic-tools/build/src/replaceESMMockingLib.js",
"./node_modules/gapic-tools/build/src/replaceImportMetaUrl.js",
"./node_modules/gapic-tools/build/src/toggleESMFlagVariable.js"
]
}
11 changes: 11 additions & 0 deletions baselines/bigquery-v2-esm/.eslintignore.baseline
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
**/node_modules
**/.coverage
build/
docs/
protos/
system-test/
samples/
esm/src/**/*.d.ts
esm/test/**/*.d.ts
esm/system-test/**/*.d.ts
esm/system-test/fixtures/sample/src/*.ts
3 changes: 3 additions & 0 deletions baselines/bigquery-v2-esm/.eslintrc.json.baseline
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": "./node_modules/gts"
}
15 changes: 15 additions & 0 deletions baselines/bigquery-v2-esm/.gitignore.baseline
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
**/*.log
**/node_modules
/.coverage
/coverage
/.nyc_output
/docs/
/out/
/build/
system-test/secrets.js
system-test/*key.json
*.lock
.DS_Store
package-lock.json
__pycache__
esm/**/*.d.ts
54 changes: 54 additions & 0 deletions baselines/bigquery-v2-esm/.jsdoc.cjs.baseline
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
// Copyright 2024 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// ** This file is automatically generated by gapic-generator-typescript. **
// ** https://github.com/googleapis/gapic-generator-typescript **
// ** All changes to this file may be overwritten. **


module.exports = {
opts: {
readme: './README.md',
package: './package.json',
template: './node_modules/jsdoc-fresh',
recurse: true,
verbose: true,
destination: './docs/'
},
plugins: [
'plugins/markdown',
'jsdoc-region-tag'
],
source: {
excludePattern: '(^|\\/|\\\\)[._]',
include: [
'build/src',
'protos'
],
includePattern: '\\.js$'
},
templates: {
copyright: 'Copyright 2024 Google LLC',
includeDate: false,
sourceFiles: false,
systemName: 'bigquery',
theme: 'lumen',
default: {
outputSourceFiles: false
}
},
markdown: {
idInHeadings: true
}
};
33 changes: 33 additions & 0 deletions baselines/bigquery-v2-esm/.mocharc.cjs.baseline
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// Copyright 2024 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// ** This file is automatically generated by gapic-generator-typescript. **
// ** https://github.com/googleapis/gapic-generator-typescript **
// ** All changes to this file may be overwritten. **

const config = {
"enable-source-maps": true,
"throw-deprecation": true,
"timeout": 10000
}
if (process.env.MOCHA_THROW_DEPRECATION === 'false') {
delete config['throw-deprecation'];
}
if (process.env.MOCHA_REPORTER) {
config.reporter = process.env.MOCHA_REPORTER;
}
if (process.env.MOCHA_REPORTER_OUTPUT) {
config['reporter-option'] = `output=${process.env.MOCHA_REPORTER_OUTPUT}`;
}
module.exports = config
22 changes: 22 additions & 0 deletions baselines/bigquery-v2-esm/.prettierrc.cjs.baseline
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Copyright 2024 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// ** This file is automatically generated by gapic-generator-typescript. **
// ** https://github.com/googleapis/gapic-generator-typescript **
// ** All changes to this file may be overwritten. **


module.exports = {
...require('gts/.prettierrc.json')
}
1 change: 1 addition & 0 deletions baselines/bigquery-v2-esm/README.md.baseline
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Bigquery: Nodejs Client
56 changes: 56 additions & 0 deletions baselines/bigquery-v2-esm/esm/src/index.ts.baseline
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
// Copyright 2024 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// ** This file is automatically generated by gapic-generator-typescript. **
// ** https://github.com/googleapis/gapic-generator-typescript **
// ** All changes to this file may be overwritten. **

import * as v2 from './v2/index.js';
const DatasetServiceClient = v2.DatasetServiceClient;
type DatasetServiceClient = v2.DatasetServiceClient;
const JobServiceClient = v2.JobServiceClient;
type JobServiceClient = v2.JobServiceClient;
const ModelServiceClient = v2.ModelServiceClient;
type ModelServiceClient = v2.ModelServiceClient;
const ProjectServiceClient = v2.ProjectServiceClient;
type ProjectServiceClient = v2.ProjectServiceClient;
const RoutineServiceClient = v2.RoutineServiceClient;
type RoutineServiceClient = v2.RoutineServiceClient;
const RowAccessPolicyServiceClient = v2.RowAccessPolicyServiceClient;
type RowAccessPolicyServiceClient = v2.RowAccessPolicyServiceClient;
const TableServiceClient = v2.TableServiceClient;
type TableServiceClient = v2.TableServiceClient;
export {
v2,
DatasetServiceClient,
JobServiceClient,
ModelServiceClient,
ProjectServiceClient,
RoutineServiceClient,
RowAccessPolicyServiceClient,
TableServiceClient,
};
export default {
v2,
DatasetServiceClient,
JobServiceClient,
ModelServiceClient,
ProjectServiceClient,
RoutineServiceClient,
RowAccessPolicyServiceClient,
TableServiceClient,
};
// @ts-ignore
import * as protos from '../../protos/protos.js';
export {protos};
20 changes: 20 additions & 0 deletions baselines/bigquery-v2-esm/esm/src/json-helper.cjs.baseline
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Copyright 2024 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable node/no-missing-require */
function getJSON(path) {
return require(path);
}

exports.getJSON = getJSON;
Loading
Loading