Merge pull request #555 from googleads/release-V19.0.0-51a22cdea420e6…

…97ea7b Changes for release V19.0.0.
googleads · Mar 13, 2024 · 262b5a1 · 262b5a1
2 parents cb9adbd + e6280c5
commit 262b5a1
Show file tree

Hide file tree

Showing 15 changed files with 46 additions and 40 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+19.0.0
+======
+- Removed support for .NET 5.0.
+- Added support for .NET 8.0.
+- Added support for user-defined gRPC interceptors.
+
 18.1.0
 ======
 - Added support for version 16.0 of the Google Ads API.

diff --git a/Google.Ads.Gax/src/Google.Ads.Gax.csproj b/Google.Ads.Gax/src/Google.Ads.Gax.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <Title>Google Ads GAPIC Extensions Dotnet Client Library</Title>
     <PackageId>Google.Ads.Gax</PackageId>
-    <Version>3.2.0</Version>
+    <Version>4.0.0</Version>
     <Description>This library provides functionality that makes it easier to work with Generated
     API Client GAPIC client libraries for Google's Ads APIs.</Description>
     <PackageReleaseNotes>https://github.com/googleads/google-ads-dotnet/blob/main/ChangeLog</PackageReleaseNotes>
@@ -21,7 +21,7 @@
   </PropertyGroup>
   <!-- build properties -->
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.1;net472;net5.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>netstandard2.1;net472;net6.0;net8.0</TargetFrameworks>
     <AssemblyName>Google.Ads.Gax</AssemblyName>
     <RootNamespace>Google.Ads.Gax</RootNamespace>
     <SignAssembly>true</SignAssembly>
@@ -31,8 +31,8 @@
     <IncludeSource>true</IncludeSource>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <AssemblyVersion>3.2.0</AssemblyVersion>
-    <FileVersion>3.2.0</FileVersion>
+    <AssemblyVersion>4.0.0</AssemblyVersion>
+    <FileVersion>4.0.0</FileVersion>
     <LangVersion>latest</LangVersion>
   </PropertyGroup>
   <ItemGroup>

diff --git a/Google.Ads.Gax/tests/Google.Ads.Gax.Tests.csproj b/Google.Ads.Gax/tests/Google.Ads.Gax.Tests.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
   <PropertyGroup>
-    <TargetFrameworks>net5.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
     <RootNamespace>Google.Ads.Gax.Tests</RootNamespace>
     <AssemblyName>Google.Ads.Gax.Tests</AssemblyName>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>

diff --git a/Google.Ads.Gax/tests/TestUtilities/Google.Ads.Gax.TestUtilities.csproj b/Google.Ads.Gax/tests/TestUtilities/Google.Ads.Gax.TestUtilities.csproj
@@ -20,7 +20,7 @@
   </PropertyGroup>
   <!-- build properties -->
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.1;net472;net5.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>netstandard2.1;net472;net6.0;net8.0</TargetFrameworks>
     <AssemblyName>Google.Ads.Gax.TestUtilities</AssemblyName>
     <RootNamespace>Google.Ads.Gax.TestUtilities</RootNamespace>
     <SignAssembly>true</SignAssembly>

diff --git a/Google.Ads.Gax/tests/TestUtilities/Hello.cs b/Google.Ads.Gax/tests/TestUtilities/Hello.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: Hello.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021
+#pragma warning disable 1591, 0612, 3021, 8981
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/Google.Ads.GoogleAds.Core/src/Google.Ads.GoogleAds.Core.csproj b/Google.Ads.GoogleAds.Core/src/Google.Ads.GoogleAds.Core.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <Title>Google Ads API Core Dotnet Client Library</Title>
     <PackageId>Google.Ads.GoogleAds.Core</PackageId>
-    <Version>3.2.0</Version>
+    <Version>4.0.0</Version>
     <Description>This library provides you with functionality to access the Google Ads API. The Google Ads API is the modern programmatic interface to Google Ads and the next generation of the AdWords API. See https://developers.google.com/google-ads/api to learn more about Google Ads API.</Description>
     <PackageReleaseNotes>https://github.com/googleads/google-ads-dotnet/blob/master/ChangeLog</PackageReleaseNotes>
     <PackageTags>GoogleAds Google</PackageTags>
@@ -20,7 +20,7 @@
   </PropertyGroup>
   <!-- build properties -->
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.1;net472;net5.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>netstandard2.1;net472;net6.0;net8.0</TargetFrameworks>
     <AssemblyName>Google.Ads.GoogleAds.Core</AssemblyName>
     <RootNamespace>Google.Ads.GoogleAds</RootNamespace>
     <SignAssembly>true</SignAssembly>
@@ -30,8 +30,8 @@
     <IncludeSource>true</IncludeSource>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <AssemblyVersion>3.2.0</AssemblyVersion>
-    <FileVersion>3.2.0</FileVersion>
+    <AssemblyVersion>4.0.0</AssemblyVersion>
+    <FileVersion>4.0.0</FileVersion>
     <LangVersion>latest</LangVersion>
   </PropertyGroup>
   <ItemGroup>
@@ -40,7 +40,7 @@
     <None Include="..\..\logo.png" Pack="true" PackagePath="" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Condition="!Exists('..\..\Google.Ads.Gax\src\Google.Ads.Gax.csproj')" Include="Google.Ads.Gax" Version="3.2.0" />
+    <PackageReference Condition="!Exists('..\..\Google.Ads.Gax\src\Google.Ads.Gax.csproj')" Include="Google.Ads.Gax" Version="4.0.0" />
     <ProjectReference Condition="Exists('..\..\Google.Ads.Gax\src\Google.Ads.Gax.csproj')" Include="..\..\Google.Ads.Gax\src\Google.Ads.Gax.csproj" />
     <PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" />
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.1" />

diff --git a/Google.Ads.GoogleAds.Core/tests/Google.Ads.GoogleAds.Core.Tests.csproj b/Google.Ads.GoogleAds.Core/tests/Google.Ads.GoogleAds.Core.Tests.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
   <PropertyGroup>
-    <TargetFrameworks>net5.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
     <RootNamespace>Google.Ads.GoogleAds.Tests</RootNamespace>
     <AssemblyName>Google.Ads.GoogleAds.Core.Tests</AssemblyName>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>

diff --git a/Google.Ads.GoogleAds.Extensions/src/Google.Ads.GoogleAds.Extensions.csproj b/Google.Ads.GoogleAds.Extensions/src/Google.Ads.GoogleAds.Extensions.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <Title>Google Ads API Dotnet Client Library Extensions</Title>
     <PackageId>Google.Ads.GoogleAds.Extensions</PackageId>
-    <Version>1.1.0</Version>
+    <Version>2.0.0</Version>
     <Description>This library provides you with extensions for the Google Ads API client library. The Google Ads API is the modern programmatic interface to Google Ads. See https://developers.google.com/google-ads/api to learn more about Google Ads API.</Description>
     <PackageReleaseNotes>https://github.com/googleads/google-ads-dotnet/blob/master/ChangeLog</PackageReleaseNotes>
     <PackageTags>GoogleAds Google</PackageTags>
@@ -21,7 +21,7 @@
   </PropertyGroup>
   <!-- build properties -->
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.1;net472;net5.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>netstandard2.1;net472;net6.0;net8.0</TargetFrameworks>
     <AssemblyName>Google.Ads.GoogleAds.Config</AssemblyName>
     <RootNamespace>Google.Ads.GoogleAds</RootNamespace>
     <SignAssembly>true</SignAssembly>
@@ -31,8 +31,8 @@
     <IncludeSource>true</IncludeSource>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <AssemblyVersion>1.1.0</AssemblyVersion>
-    <FileVersion>1.1.0</FileVersion>
+    <AssemblyVersion>2.0.0</AssemblyVersion>
+    <FileVersion>2.0.0</FileVersion>
     <LangVersion>latest</LangVersion>
   </PropertyGroup>
   <ItemGroup>
@@ -45,9 +45,9 @@
     <None Include="..\..\logo.png" Pack="true" PackagePath="" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Condition="!Exists('..\..\Google.Ads.GoogleAds.Core\src\Google.Ads.GoogleAds.Core.csproj')" Include="Google.Ads.GoogleAds.Core" Version="3.2.0" />
+    <PackageReference Condition="!Exists('..\..\Google.Ads.GoogleAds.Core\src\Google.Ads.GoogleAds.Core.csproj')" Include="Google.Ads.GoogleAds.Core" Version="4.0.0" />
     <ProjectReference Condition="Exists('..\..\Google.Ads.GoogleAds.Core\src\Google.Ads.GoogleAds.Core.csproj')" Include="..\..\Google.Ads.GoogleAds.Core\src\Google.Ads.GoogleAds.Core.csproj" />
-    <PackageReference Condition="!Exists('..\..\Google.Ads.Gax\src\Google.Ads.Gax.csproj')" Include="Google.Ads.Gax" Version="3.2.0" />
+    <PackageReference Condition="!Exists('..\..\Google.Ads.Gax\src\Google.Ads.Gax.csproj')" Include="Google.Ads.Gax" Version="4.0.0" />
     <ProjectReference Condition="Exists('..\..\Google.Ads.Gax\src\Google.Ads.Gax.csproj')" Include="..\..\Google.Ads.Gax\src\Google.Ads.Gax.csproj" />
     <PackageReference Include="Microsoft.Extensions.Configuration" Version="6.0.1" />
     <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />

diff --git a/Google.Ads.GoogleAds.Extensions/tests/Google.Ads.GoogleAds.Extensions.Tests.csproj b/Google.Ads.GoogleAds.Extensions/tests/Google.Ads.GoogleAds.Extensions.Tests.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
   <PropertyGroup>
-    <TargetFrameworks>net5.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
     <RootNamespace>Google.Ads.GoogleAds.Extensions.Tests</RootNamespace>
     <AssemblyName>Google.Ads.GoogleAds.Extensions.Tests</AssemblyName>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>

diff --git a/Google.Ads.GoogleAds/buildscript/common.sh b/Google.Ads.GoogleAds/buildscript/common.sh
@@ -101,19 +101,19 @@ function dotnet_library::extract_keystore_secrets() {
 ########################################################################
 function dotnet_library::install_dotnet() {
   # Note:
-  # * dotnet-sdk-6.0 is capable of compiling the code to all the 4
-  #  frameworks - net6.0, net5.0, net472 and netcoreapp3.1. Hence we
-  #  install dotnet-sdk-6.0.
+  # * dotnet-sdk-8.0 is capable of compiling the code to all the frameworks
+  #  we need - net8.0, net6.0, net472 and netcoreapp3.1. Hence we
+  #  install dotnet-sdk-8.0.
   # * To run the tests, we need the corresponding runtimes to be installed.
-  #   *  dotnet-runtime-5.0 is installed to run tests for net5.0.
+  #   *  dotnet-runtime-6.0 is installed to run tests for net6.0.
   #   *  The library supports netstandard2.0, but Microsoft expects test
   #      assemblies to be compiled against executable targets even though
   #      the test itself is written as a library. So we target
   #      netcoreapp3.1 instead of netstandard2.0 in the
   #      various test assemblies and install dotnet-runtime-3.1 to run
   #      the tests.
-  #   *  .NET 6.0 runtime is included in dotnet-sdk-6.0, so we don't
-  #      install dotnet-runtime-6.0.
+  #   *  .NET 8.0 runtime is included in dotnet-sdk-8.0, so we don't
+  #      install dotnet-runtime-8.0.
   #   *  We don't install mono (or run tests for .NET 472). Pretty much
   #      no one uses mono, and mono itself is known to have multiple
   #      deviations from the .NET Framework 472, so testing for .NET 472
@@ -122,7 +122,7 @@ function dotnet_library::install_dotnet() {
   # * We use Microsoft's dotnet-install.sh and let it deal with resolving
   #   download locations and platform-specific builds.
 
-  # Install dotnet 3.1, 5.0, 6.0.
+  # Install dotnet 6.0, 8.0.
   echo "Installing .NET"
   echo "==============="
 
@@ -131,8 +131,8 @@ function dotnet_library::install_dotnet() {
     "${REPO_ROOT}/dotnet_setup/dotnet-install.sh"
   pushd "${REPO_ROOT}/dotnet_setup"
   chmod 755 ./dotnet-install.sh
-  ./dotnet-install.sh --install-dir . --version 6.0.300
-  ./dotnet-install.sh --install-dir . --runtime dotnet --version 5.0.13
+  ./dotnet-install.sh --install-dir . --channel 8.0
+  ./dotnet-install.sh --install-dir . --runtime dotnet --version 6.0.27
   ./dotnet-install.sh --install-dir . --runtime dotnet --version 3.1.22
   DOTNET_BINARY="${REPO_ROOT}/dotnet_setup/dotnet"
   popd

diff --git a/...entication/AuthenticateInAspNetCoreApplication/AuthenticateInAspNetCoreApplication.csproj b/...entication/AuthenticateInAspNetCoreApplication/AuthenticateInAspNetCoreApplication.csproj
@@ -18,7 +18,7 @@
     <PackageReference Condition="!Exists('..\..\..\src\Google.Ads.GoogleAds.csproj')"
         Include="Google.Ads.GoogleAds" Version="19.0.0" />
     <PackageReference Condition="!Exists('..\..\..\..\Google.Ads.GoogleAds.Extensions\src\Google.Ads.GoogleAds.Extensions.csproj')"
-        Include="Google.Ads.GoogleAds.Extensions" Version="1.1.0" />
+        Include="Google.Ads.GoogleAds.Extensions" Version="2.0.0" />
 
   </ItemGroup>
 

diff --git a/....GoogleAds/examples/Authentication/GenerateUserCredentials/GenerateUserCredentials.csproj b/....GoogleAds/examples/Authentication/GenerateUserCredentials/GenerateUserCredentials.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
   <PropertyGroup>
-    <TargetFrameworks>net6.0</TargetFrameworks>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
     <Title>GenerateUserCredentials - Google Ads API Dotnet Client Library</Title>
     <PackageId>Google.Ads.GoogleAds.GenerateUserCredentials</PackageId>
     <Version>1.0.0</Version>

diff --git a/Google.Ads.GoogleAds/examples/Google.Ads.GoogleAds.Examples.csproj b/Google.Ads.GoogleAds/examples/Google.Ads.GoogleAds.Examples.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
   <PropertyGroup>
-    <TargetFrameworks>net472;netcoreapp3.1;net5.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>net472;net6.0;net8.0</TargetFrameworks>
     <RootNamespace>Google.Ads.GoogleAds.Examples</RootNamespace>
     <AssemblyName>Google.Ads.GoogleAds.Examples</AssemblyName>
     <OutputType>Exe</OutputType>
@@ -34,9 +34,9 @@
   </ItemGroup>
   <ItemGroup>
    <!-- Include local projects over nuget dependencies if available -->
-    <PackageReference Condition="!Exists('..\src\Google.Ads.GoogleAds.csproj')" Include="Google.Ads.GoogleAds" Version="18.0.0" />
+    <PackageReference Condition="!Exists('..\src\Google.Ads.GoogleAds.csproj')" Include="Google.Ads.GoogleAds" Version="19.0.0" />
     <ProjectReference Condition="Exists('..\src\Google.Ads.GoogleAds.csproj')" Include="..\src\Google.Ads.GoogleAds.csproj" />
-    <PackageReference Condition="!Exists('..\..\Google.Ads.GoogleAds.Extensions\src\Google.Ads.GoogleAds.Extensions.csproj')" Include="Google.Ads.GoogleAds.Extensions" Version="1.1.0" />
+    <PackageReference Condition="!Exists('..\..\Google.Ads.GoogleAds.Extensions\src\Google.Ads.GoogleAds.Extensions.csproj')" Include="Google.Ads.GoogleAds.Extensions" Version="2.0.0" />
     <ProjectReference Condition="Exists('..\..\Google.Ads.GoogleAds.Extensions\src\Google.Ads.GoogleAds.Extensions.csproj')" Include="..\..\Google.Ads.GoogleAds.Extensions\src\Google.Ads.GoogleAds.Extensions.csproj" />
   </ItemGroup>
   <ItemGroup>

diff --git a/Google.Ads.GoogleAds/src/Google.Ads.GoogleAds.csproj b/Google.Ads.GoogleAds/src/Google.Ads.GoogleAds.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <Title>Google Ads API Dotnet Client Library</Title>
     <PackageId>Google.Ads.GoogleAds</PackageId>
-    <Version>18.1.0</Version>
+    <Version>19.0.0</Version>
     <Description>This library provides you with functionality to access the Google Ads API. The Google Ads API is the modern programmatic interface to Google Ads and the next generation of the AdWords API. See https://developers.google.com/google-ads/api to learn more about Google Ads API.</Description>
     <PackageReleaseNotes>https://github.com/googleads/google-ads-dotnet/blob/master/ChangeLog</PackageReleaseNotes>
     <PackageTags>GoogleAds Google</PackageTags>
@@ -20,7 +20,7 @@
   </PropertyGroup>
   <!-- build properties -->
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.1;net472;net5.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>netstandard2.1;net472;net6.0</TargetFrameworks>
     <AssemblyName>Google.Ads.GoogleAds</AssemblyName>
     <RootNamespace>Google.Ads.GoogleAds</RootNamespace>
     <SignAssembly>true</SignAssembly>
@@ -30,8 +30,8 @@
     <IncludeSource>true</IncludeSource>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <AssemblyVersion>18.1.0</AssemblyVersion>
-    <FileVersion>18.1.0</FileVersion>
+    <AssemblyVersion>19.0.0</AssemblyVersion>
+    <FileVersion>19.0.0</FileVersion>
     <LangVersion>latest</LangVersion>
   </PropertyGroup>
   <ItemGroup>
@@ -40,7 +40,7 @@
     <None Include="..\..\logo.png" Pack="true" PackagePath="" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Condition="!Exists('..\..\Google.Ads.GoogleAds.Core\src\Google.Ads.GoogleAds.Core.csproj')" Include="Google.Ads.GoogleAds.Core" Version="3.2.0" />
+    <PackageReference Condition="!Exists('..\..\Google.Ads.GoogleAds.Core\src\Google.Ads.GoogleAds.Core.csproj')" Include="Google.Ads.GoogleAds.Core" Version="4.0.0" />
     <ProjectReference Condition="Exists('..\..\Google.Ads.GoogleAds.Core\src\Google.Ads.GoogleAds.Core.csproj')" Include="..\..\Google.Ads.GoogleAds.Core\src\Google.Ads.GoogleAds.Core.csproj" />
   </ItemGroup>
   <ItemGroup>

diff --git a/Google.Ads.GoogleAds/tests/Google.Ads.GoogleAds.Tests.csproj b/Google.Ads.GoogleAds/tests/Google.Ads.GoogleAds.Tests.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
   <PropertyGroup>
-    <TargetFrameworks>net5.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
     <RootNamespace>Google.Ads.GoogleAds.Tests</RootNamespace>
     <AssemblyName>Google.Ads.GoogleAds.Tests</AssemblyName>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>