Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose ProcessPromise stage #1077

Merged
merged 14 commits into from
Jan 11, 2025

Conversation

easymikey
Copy link
Contributor

@easymikey easymikey commented Jan 10, 2025

@antongolub Did you mean something like that?

This is a draft, I need to understand if I chose the right approach.

Fixes #967

  • Tests pass
  • Appropriate changes to README are included in PR

@easymikey easymikey force-pushed the refactor-proccess-promise branch from e74763e to ad5c167 Compare January 10, 2025 15:23
@easymikey easymikey marked this pull request as draft January 10, 2025 17:28
@easymikey easymikey changed the title Draft: refactor: add internal state marker refactor: add internal state marker Jan 10, 2025
@antongolub
Copy link
Collaborator

antongolub commented Jan 10, 2025

Provide a test for get stage(). And state machine description for the docs plz.

@antongolub antongolub self-requested a review January 10, 2025 18:38
@easymikey
Copy link
Contributor Author

Provide a test for get stage(). And state machine description for the docs plz.

Okey, I'll finish today

@easymikey easymikey marked this pull request as ready for review January 11, 2025 13:01
src/core.ts Outdated Show resolved Hide resolved
docs/process-promise.md Outdated Show resolved Hide resolved
@easymikey easymikey requested a review from antongolub January 11, 2025 18:45
test/core.test.js Outdated Show resolved Hide resolved
test/core.test.js Outdated Show resolved Hide resolved
test/core.test.js Outdated Show resolved Hide resolved
@antongolub antongolub self-requested a review January 11, 2025 21:23
Copy link
Collaborator

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@antongolub antongolub merged commit 49a82c4 into google:main Jan 11, 2025
24 checks passed
@antongolub antongolub changed the title refactor: add internal state marker feat: expose ProcessPromise stage Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: refactor ProcessPromise internal state markers
2 participants