Include package-infos in repackaged transitive classes

This is related to unknown commit, which ensured that jdeps include package-infos. PiperOrigin-RevId: 668103888
google · Aug 28, 2024 · 5df23f1 · 5df23f1
1 parent 15ed1be
commit 5df23f1
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 2 deletions.
diff --git a/java/com/google/turbine/deps/Dependencies.java b/java/com/google/turbine/deps/Dependencies.java
@@ -165,7 +165,7 @@ private static void addSuperTypes(
     }
   }
 
-  private static void addPackageInfos(Set<ClassSymbol> closure, BindingResult bound) {
+  static void addPackageInfos(Set<ClassSymbol> closure, BindingResult bound) {
     Set<ClassSymbol> packages = new LinkedHashSet<>();
     for (ClassSymbol sym : closure) {
       String packageName = sym.packageName();

diff --git a/java/com/google/turbine/deps/Transitive.java b/java/com/google/turbine/deps/Transitive.java
@@ -45,7 +45,9 @@ public final class Transitive {
   public static ImmutableMap<String, byte[]> collectDeps(
       ClassPath bootClassPath, BindingResult bound) {
     ImmutableMap.Builder<String, byte[]> transitive = ImmutableMap.builder();
-    for (ClassSymbol sym : superClosure(bound)) {
+    Set<ClassSymbol> closure = superClosure(bound);
+    Dependencies.addPackageInfos(closure, bound);
+    for (ClassSymbol sym : closure) {
       BytecodeBoundClass info = bound.classPathEnv().get(sym);
       if (info == null) {
         // the symbol wasn't loaded from the classpath

diff --git a/javatests/com/google/turbine/deps/TransitiveTest.java b/javatests/com/google/turbine/deps/TransitiveTest.java
@@ -305,6 +305,44 @@ public void childClass() throws Exception {
         .inOrder();
   }
 
+  @Test
+  public void packageInfo() throws Exception {
+    Path libPackageInfo =
+        runTurbine(
+            new SourceBuilder()
+                .addSourceLines(
+                    "p/Anno.java",
+                    "package p;",
+                    "import java.lang.annotation.Retention;",
+                    "import static java.lang.annotation.RetentionPolicy.RUNTIME;",
+                    "@Retention(RUNTIME)",
+                    "@interface Anno {}")
+                .addSourceLines(
+                    "p/package-info.java", //
+                    "@Anno",
+                    "package p;")
+                .build(),
+            ImmutableList.of());
+
+    Path liba =
+        runTurbine(
+            new SourceBuilder()
+                .addSourceLines(
+                    "p/P.java", //
+                    "package p;",
+                    "public class P {}")
+                .build(),
+            ImmutableList.of(libPackageInfo));
+
+    assertThat(readJar(liba).keySet())
+        .containsExactly(
+            "META-INF/",
+            "META-INF/MANIFEST.MF",
+            "META-INF/TRANSITIVE/p/package-info.class",
+            "p/P.class")
+        .inOrder();
+  }
+
   private Path runTurbine(ImmutableList<Path> sources, ImmutableList<Path> classpath)
       throws IOException {
     Path out = temporaryFolder.newFolder().toPath().resolve("out.jar");