Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve unsoundness caught by pytype --strict-none-binding. #3250

Merged
merged 3 commits into from
Dec 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion api_client/python/timesketch_api_client/aggregation.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import getpass
import json
import logging
from typing import Any

import altair
import pandas
Expand All @@ -41,6 +42,8 @@ class Aggregation(resource.SketchResource):
saved search.
"""

resource_data: dict[str, Any]

def __init__(self, sketch):
self._created_at = ""
self._name = ""
Expand Down Expand Up @@ -307,7 +310,7 @@ def description(self, description):
"""Set the description of an aggregation."""
if "meta" not in self.resource_data:
return
meta = self.resource_data.get("meta")
meta = self.resource_data.get("meta", {})
meta["description"] = description

@property
Expand Down
13 changes: 10 additions & 3 deletions api_client/python/timesketch_api_client/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,11 @@ def __init__(
self._flow = None

if not create_session:
self.session = None
self._session = None
return

try:
self.session = self._create_session(
self._session = self._create_session(
username,
password,
verify=verify,
Expand Down Expand Up @@ -145,13 +145,20 @@ def version(self):

return "API Client: {0:s}".format(version.get_version())

@property
def session(self):
"""Property that returns the session object."""
if self._session is None:
raise ValueError("Session is not set.")
return self._session

def set_credentials(self, credential_object):
"""Sets the credential object."""
self.credentials = credential_object

def set_session(self, session_object):
"""Sets the session object."""
self.session = session_object
self._session = session_object

def _authenticate_session(self, session, username, password):
"""Post username/password to authenticate the HTTP session.
Expand Down
6 changes: 4 additions & 2 deletions api_client/python/timesketch_api_client/graph.py
Original file line number Diff line number Diff line change
Expand Up @@ -231,12 +231,14 @@ def from_graph(self, graph_obj):
self._created_at = time
self._updated_at = time

def from_manual(self, data, **kwargs): # pylint: disable=arguments-differ
def from_manual(
self, data, **kwargs
): # pylint: disable=arguments-differ; pytype: disable=signature-mismatch
"""Generate a new graph using a dictionary.
Args:
data (dict): A dictionary of dictionaries adjacency representation.
kwargs (dict[str, object]): Depending on the resource they may
**kwargs (dict[str, object]): Depending on the resource they may
require different sets of arguments to be able to run a raw
API request.
Expand Down
Loading