Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken unit test workflows #3231

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Nov 27, 2024

This PR will fix the broken unit test workflows.

The problem is with this workflow step:

      - name: Install dependencies
        run: |
          pip install pipenv
          pipenv install -d
          pipenv install -r test_requirements.txt

Looks like pipenv stopped installing the test dependencies in the last step. So pytest etc. was missing from the rest of the workflow resulting in errors.

By changing the last step to pipenv run pip install -r test_requirements.txt we ensure the test dependencies are installed in the pipenv and available for running those tests.

@jkppr jkppr added the Bug label Nov 27, 2024
@jkppr jkppr self-assigned this Nov 27, 2024
@jkppr jkppr changed the title Debugging broken unit test workflows Fix broken unit test workflows Nov 27, 2024
@jkppr jkppr requested review from berggren and tomchop November 27, 2024 16:30
@jkppr jkppr merged commit 7c1b089 into google:master Nov 27, 2024
24 checks passed
@jkppr jkppr deleted the fix_unit_test_workflows branch November 27, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants