Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws cloudtrail tagger #3224

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Aws cloudtrail tagger #3224

merged 4 commits into from
Nov 27, 2024

Conversation

raihalea
Copy link
Contributor

@raihalea raihalea commented Nov 8, 2024

IMPORTANT: All Pull Requests should be connected to an issue, if you don't
have an issue, please start by creating an issue and link it to the PR.

Please provide enough information so that others can review your pull request:

  • What existing problem does this PR solve?

    • This PR adds AWS CloudTrail configurations to data/tags.yaml.
  • What new feature is being introduced with this PR?

    • This PR enables tagging of AWS CloudTrail events in Plaso format using the Tagger analyzer.

Checks

  • All tests succeed.
  • Unit tests added.
  • e2e tests added.
  • Documentation updated.

Closing issues

closes #3216

@raihalea
Copy link
Contributor Author

raihalea commented Nov 8, 2024

Hi @jkppr,

Could you please review the PR when you have a moment?

@jkppr jkppr self-requested a review November 11, 2024 08:54
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for contributing those tag configs! I'll need to fix the unit tests (unrelated to this PR) and will merge it afterwards.

@jkppr jkppr merged commit 4028481 into google:master Nov 27, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS CloudTrail Analyzer
2 participants