Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent opensearch from aggregating across all indices. #3192

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Oct 1, 2024

This PR addresses an issue where Timesketch attempts to execute an OpenSearch query with an empty index list when fetching labels for sketches without active timelines. This defaults to querying _all indices, which can lead to performance issues and the "got more than 100 headers" error due to excessive task management headers and/or large responses in the aggregation.

The following changes were made:

  • In the SketchResource.get function (timesketch/api/v1/resources/sketch.py), a conditional check was added to ensure get_filter_labels is called only if sketch_indices is not empty. If the list is empty (no indices to query), an empty list is directly assigned to filter_labels in the metadata.
  • In the get_filter_labels function (timesketch/lib/datastores/opensearch.py) a check was added at the beginning of the function to immediately return an empty list if the provided indices parameter is empty. This prevents the aggregation query from being constructed and executed unnecessarily. Explanatory comments were added to clarify the purpose of these changes.

These modifications prevent querying _all indices with empty sketch_indices, improving performance and preventing header limit errors when fetching sketch details for empty sketches or sketches without active timelines.

Closing issues

closes #3191

@jkppr jkppr requested a review from berggren October 1, 2024 13:44
@jkppr jkppr self-assigned this Oct 1, 2024
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkppr jkppr merged commit fa03fc9 into google:master Oct 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sketch label aggregation scaling issue
2 participants