-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left panel timeline management #2999
Left panel timeline management #2999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this great feature. I fixed some minor UI stuff myself but please take a look at the following comments.
timesketch/frontend-ng/src/components/Explore/TimelineComponent.vue
Outdated
Show resolved
Hide resolved
…q/timesketch into timelines-left-panel-iteration-1
Thanks for the input @berggren . I have included your recommended changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks for this great feature!
Much of the diff stems from Pulling out a generic TimelineComponent that provides slots to customize the template. It can now be used to display chips (TimelineChip) or table rows (used inside TimelinesTable).
I also added a slot to the UploadForm component to make it more generic and not restrict its usage to buttons. The specific one is now called (UploadFormButton).