Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New empty-state and left panel bugfix #2991

Merged
merged 8 commits into from
Nov 24, 2023
Merged

New empty-state and left panel bugfix #2991

merged 8 commits into from
Nov 24, 2023

Conversation

berggren
Copy link
Contributor

@berggren berggren commented Nov 22, 2023 •
edited
Loading

This PR fixes a bug where the left navigation drawer overlapped the canvas main section. A couple of other fixes:

  • Reworked the empty state page to vertically align content and add art
  • Removed old unused (and not functional) resize panel code
  • Use v-model for show/hide panel instead of width
Screenshot 2023-11-22 at 14 02 38

Closing issues
closes #2968
closes #2992

@berggren berggren requested a review from jkppr November 22, 2023 13:09
jkppr
jkppr requested changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits below

timesketch/frontend-ng/src/views/Sketch.vue Show resolved Hide resolved
timesketch/frontend-ng/src/views/Sketch.vue Outdated Show resolved Hide resolved
@jkppr jkppr mentioned this pull request Nov 22, 2023
Closed
@jkppr
Copy link
Collaborator

jkppr commented Nov 22, 2023

As discussed, added an issue to track the follow-up task for the "archived sketch" page: #2992

@berggren berggren self-assigned this Nov 22, 2023
@berggren berggren added this to the Release: 20231206 milestone Nov 22, 2023
@berggren
Copy link
Contributor Author

As discussed, added an issue to track the follow-up task for the "archived sketch" page: #2992

I ended up fixing it in this PR. PTAL

(the unit test fail seem to be a temporary issue with the apt mirror)

jkppr
jkppr approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@berggren berggren changed the title New empty state page and left panel bugfix New empty-state and left panel bugfix Nov 24, 2023
@jkppr jkppr merged commit d8e8b29 into master Nov 24, 2023
26 checks passed
@jkppr jkppr deleted the ui-fix branch November 24, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkppr jkppr jkppr approved these changes

Assignees

@berggren berggren

Labels
None yet
Projects
None yet
Milestone
Release: 20231206
Development

Successfully merging this pull request may close these issues.

Update the Sketch is archived page UI bug: LeftPanel overlaps canvas
2 participants
@berggren @jkppr