Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a copy action to filter chips #2990

Merged
merged 7 commits into from
Dec 1, 2023
Merged

Adding a copy action to filter chips #2990

merged 7 commits into from
Dec 1, 2023

Conversation

JohannesLks
Copy link
Contributor

Copy added to time filter
grafik

Copy added to term filter

copy.mp4

Checks

  • All tests succeed.
  • Unit tests added.
  • e2e tests added.
  • Documentation updated.

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes
(if such).

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@JohannesLks JohannesLks marked this pull request as draft November 21, 2023 20:39
@JohannesLks JohannesLks marked this pull request as ready for review November 21, 2023 20:39
@JohannesLks JohannesLks changed the title filter chip content cannot be copied #2950 filter chip content cannot be copied Nov 21, 2023
@JohannesLks JohannesLks changed the title filter chip content cannot be copied filter chip content cannot be copied issue #2950 Nov 21, 2023
@jkppr jkppr self-requested a review November 23, 2023 08:32
@jkppr jkppr linked an issue Nov 23, 2023 that may be closed by this pull request
@jkppr jkppr added this to the Release: 20231206 milestone Nov 23, 2023
@jkppr jkppr added the Frontend label Nov 23, 2023
@JohannesLks
Copy link
Contributor Author

The linting error: Expected error to be handled (handle-callback-err) might be this part in line 576, where i forgot to implement to handle the error.

        .catch(err => {
        // Handle errors (e.g., clipboard access denied)
        });

Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to Timesketch. This is the first round of review for this feature. Please take care of the comments below.

(Note: The failing unit test can be ignored for now. The problem seems not related to your PR)

timesketch/frontend-ng/src/views/Explore.vue Outdated Show resolved Hide resolved
timesketch/frontend-ng/src/views/Explore.vue Outdated Show resolved Hide resolved
timesketch/frontend-ng/src/views/Explore.vue Outdated Show resolved Hide resolved
@JohannesLks JohannesLks requested a review from jkppr November 23, 2023 10:36
@jkppr jkppr changed the title filter chip content cannot be copied issue #2950 Adding a copy action to filter chips Dec 1, 2023
* Update the function name.
* Add quotes for the field value.
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@jkppr jkppr merged commit f01dfeb into google:master Dec 1, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filter chip content cannot be copied
2 participants