-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a copy action to filter chips #2990
Conversation
The linting error: Expected error to be handled (handle-callback-err) might be this part in line 576, where i forgot to implement to handle the error. .catch(err => {
// Handle errors (e.g., clipboard access denied)
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution to Timesketch. This is the first round of review for this feature. Please take care of the comments below.
(Note: The failing unit test can be ignored for now. The problem seems not related to your PR)
* Update the function name. * Add quotes for the field value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Copy added to time filter
Copy added to term filter
copy.mp4
Checks
Closing issues
Put
closes #XXXX
in your comment to auto-close the issue that your PR fixes(if such).