Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL/TLS support and authentication for SMTP #2940

Merged
merged 7 commits into from
Oct 25, 2023

Conversation

fazledyn-or
Copy link
Contributor

Details

While triaging your project, our bug fixing tool generated the following message(s)-

In file: utils.py, method: send_email, a clear-text protocol such as FTP, Telnet or SMTP is used. These protocols transfer data without any encryption, which expose applications to a large range of risks. iCR suggested that data should be transferred over only secure transport channels.

Changes

  • Added SSL & TLS based SMTP support in send_mail() method in timesketch/lib/utils.py
  • Added configuration related to the changes in data/timesketch.conf

CLA Requirements

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).
- Git Commit SignOff documentation

Checks

  • All tests succeed.
  • Unit tests added.
  • e2e tests added.
  • Documentation updated.

Closing issues

Closes #2939

Sponsorship and Support

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

timesketch/lib/utils.py Outdated Show resolved Hide resolved
timesketch/lib/utils.py Outdated Show resolved Hide resolved
data/timesketch.conf Outdated Show resolved Hide resolved
timesketch/lib/utils.py Outdated Show resolved Hide resolved
@berggren berggren changed the title Added SSL/TLS support and authentication for SMTP SSL/TLS support and authentication for SMTP Oct 25, 2023
@berggren berggren added this to the Release: 20231025 milestone Oct 25, 2023
@berggren berggren merged commit c7f5a91 into google:master Oct 25, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support for SSL/TLS based SMTP with authentication
2 participants