Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API client method to delete Sigma rule #2924

Merged
merged 8 commits into from
Oct 20, 2023
Merged

API client method to delete Sigma rule #2924

merged 8 commits into from
Oct 20, 2023

Conversation

jaegeral
Copy link
Collaborator

@jaegeral jaegeral commented Oct 4, 2023 •
edited
Loading

Have a Sigma rule delete method in the API client and corresponding end2end tests.

This also avoids error in end2end tests if you run them multiple times on a local machine, otherwise you would get:

Running test: test_create_sigma_rule ...Failed response: [403] Rule 5266a592-b793-11ea-b3de-bbbbbb was already found in the database FORBIDDEN
Failed response: [403] Rule 5266a592-b793-11ea-b3de-bbbbbb was already found in the database FORBIDDEN
Failed response: [403] Rule 5266a592-b793-11ea-b3de-bbbbbb was already found in the database FORBIDDEN
Failed response: [403] Rule 5266a592-b793-11ea-b3de-bbbbbb was already found in the database FORBIDDEN
Failed response: [403] Rule 5266a592-b793-11ea-b3de-bbbbbb was already found in the database FORBIDDEN

every time you run the end2end tests.

With this PR, the rules are emptied every time.

Closes #2922

@jaegeral jaegeral added API client Sigma Issued related to our Sigma integration labels Oct 4, 2023
@jaegeral jaegeral marked this pull request as ready for review October 4, 2023 12:54
@jaegeral jaegeral requested a review from tomchop October 11, 2023 07:56
@berggren berggren removed the request for review from tomchop October 17, 2023 13:38
@berggren berggren changed the title [API Client] Sigma rule delete method API client method to delete Sigma rule Oct 17, 2023
@jaegeral jaegeral merged commit da2cbcc into google:master Oct 20, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berggren berggren berggren approved these changes

Assignees
No one assigned
Labels
API client Sigma Issued related to our Sigma integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sigma] Have an API client endpoint to delete a Sigma rule
2 participants
@jaegeral @berggren