Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSV upload without timestamp_desc #2896

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Sep 19, 2023

The timestamp_desc field is a mandatory field for all Timesketch data. However, when uploading via the web UI the upload form did not trigger the mapping functionality when the timestamp_desc field was missing. This resulted in a broken timeline with the error:

Error message: Missing mandatory CSV headers.
Mandatory headers: datetime, message, timestamp_desc
Headers found in the file: datetime, timestamp, packages, message, command, display_name, timestamp_descA, parser, filename, data_type, extra_field_1
Headers provided in the mapping: None
Headers missing: timestamp_desc

This PR adds timestamp_desc to the mandatory fields wich will therefore trigger the mapping feature in the upload dialog if the field is missing.

Closing issues

closes #2630

@jkppr jkppr added the Frontend label Sep 19, 2023
@jkppr jkppr self-assigned this Sep 19, 2023
@jkppr jkppr requested a review from berggren September 19, 2023 08:49
@jkppr jkppr merged commit 52274e1 into google:master Sep 19, 2023
24 checks passed
@jkppr jkppr deleted the 2630_csv_uplaod_mapping branch September 19, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[frontend-ng] timestamp_desc missing from list of mandatory headers in upload form
2 participants