Reduce load time for the CLI client #2170
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berggren
changed the title
jaegeral
reviewed
May 17, 2023
| """Set the active sketch. | ||
|
|
||
| Args: | ||
| ctx: Click CLI context object. |
There was a problem hiding this comment.
just stumbled across this PR, any reason you removed the docstring here?
berggren
changed the title
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how we do imports in the CLI client. The current implementation has some slow imports (the API client with cloud dependencies etc). The way Click works is it imports all commands at startup.
By moving the imports in the commands to inline with the function we lazy import when needed. This speeds up the UI significantly.
I also refactored the state object, moving initializing the API client and config assistant to properties instead, with the ability to cache the objects (for commands that access them multiple times).
These changes reduced time to load the tool from ~1.4s -> ~0.2s. Making the tool much snappier to use.
importtouploadto make it more intuitive.