Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax text bounds to allow text-2.0 #433

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Relax text bounds to allow text-2.0 #433

merged 1 commit into from
Apr 5, 2022

Conversation

blackgnezdo
Copy link
Collaborator

This was tested by using an explicit override with this diff:

--- a/stack-9.2.yaml
+++ b/stack-9.2.yaml
@@ -21,5 +21,10 @@ packages:
 - proto-lens-tests
 - proto-lens-tests-dep

+extra-deps:
+  - text-2.0
+  - Cabal-3.6.3.0@sha256:ff97c442b0c679c1c9876acd15f73ac4f602b973c45bde42b43ec28265ee48f4,12459
+  - parsec-3.1.15.0@sha256:a162d4cc8884014ba35192545cad293af0529fe11497aad8834bbaaa3dfffc26,4429
+
 ghc-options:
   "$locals": -Wall -Werror

@blackgnezdo
Relax text bounds to allow text-2.0
4622e14 
This was tested by using an explicit override with this diff:

--- a/stack-9.2.yaml
+++ b/stack-9.2.yaml
@@ -21,5 +21,10 @@ packages:
 - proto-lens-tests
 - proto-lens-tests-dep

+extra-deps:
+  - text-2.0
+  - Cabal-3.6.3.0@sha256:ff97c442b0c679c1c9876acd15f73ac4f602b973c45bde42b43ec28265ee48f4,12459
+  - parsec-3.1.15.0@sha256:a162d4cc8884014ba35192545cad293af0529fe11497aad8834bbaaa3dfffc26,4429
+
 ghc-options:
   "$locals": -Wall -Werror
@blackgnezdo
Copy link
Collaborator Author

text-2.0 will be in ghc-9.4, so I might as well front-load this boundary relaxation since I'm in the area.

@blackgnezdo blackgnezdo requested a review from jinwoo April 5, 2022 03:44
@blackgnezdo
Copy link
Collaborator Author

blackgnezdo commented Apr 5, 2022 •
edited
Loading

@brandon-leapyear if you have some time, could you check if I'll cover everything by releasing these packages:

  • proto-lens
  • proto-lens-arbitrary
  • proto-lens-optparse
  • proto-lens-protobuf-types
  • proto-lens-protoc
  • proto-lens-runtime
  • proto-lens-setup

@brandon-leapyear
Copy link
Contributor

brandon-leapyear commented Apr 5, 2022 •
edited
Loading

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

At the very least, that's all that my company uses :). A quick search of Hackage indicates that that seems correct

@brandon-leapyear
Copy link
Contributor

brandon-leapyear commented Apr 5, 2022 •
edited
Loading

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

FYI @blackgnezdo proto-lens is unique in that most other packages don't need to be released for us to be able to use it; stack.yaml allows specifying github repos with commits as dependencies instead of going to Hackage. But Stack has issues doing the same with the proto-lens git repo: commercialhaskell/stack#5603

So in general, releasing proto-lens is more urgent than other packages because it's impossible to depend on it unless it's on Hackage

jinwoo
jinwoo approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@jinwoo jinwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinwoo jinwoo merged commit 01132da into google:master Apr 5, 2022
@blackgnezdo blackgnezdo deleted the ghc-9.2 branch April 5, 2022 04:23
avdv pushed a commit to avdv/proto-lens that referenced this pull request Aug 9, 2023
@blackgnezdo
Relax text bounds to allow text-2.0 (google#433)
689f88b 
This was tested by using an explicit override with this diff:

--- a/stack-9.2.yaml
+++ b/stack-9.2.yaml
@@ -21,5 +21,10 @@ packages:
 - proto-lens-tests
 - proto-lens-tests-dep

+extra-deps:
+  - text-2.0
+  - Cabal-3.6.3.0@sha256:ff97c442b0c679c1c9876acd15f73ac4f602b973c45bde42b43ec28265ee48f4,12459
+  - parsec-3.1.15.0@sha256:a162d4cc8884014ba35192545cad293af0529fe11497aad8834bbaaa3dfffc26,4429
+
 ghc-options:
   "$locals": -Wall -Werror
ylecornec pushed a commit to ylecornec/proto-lens that referenced this pull request Feb 19, 2024
@blackgnezdo
Relax text bounds to allow text-2.0 (google#433)
57e315d 
This was tested by using an explicit override with this diff:

--- a/stack-9.2.yaml
+++ b/stack-9.2.yaml
@@ -21,5 +21,10 @@ packages:
 - proto-lens-tests
 - proto-lens-tests-dep

+extra-deps:
+  - text-2.0
+  - Cabal-3.6.3.0@sha256:ff97c442b0c679c1c9876acd15f73ac4f602b973c45bde42b43ec28265ee48f4,12459
+  - parsec-3.1.15.0@sha256:a162d4cc8884014ba35192545cad293af0529fe11497aad8834bbaaa3dfffc26,4429
+
 ghc-options:
   "$locals": -Wall -Werror
ylecornec pushed a commit to ylecornec/proto-lens that referenced this pull request Feb 19, 2024
@blackgnezdo
Relax text bounds to allow text-2.0 (google#433)
5395d64 
This was tested by using an explicit override with this diff:

--- a/stack-9.2.yaml
+++ b/stack-9.2.yaml
@@ -21,5 +21,10 @@ packages:
 - proto-lens-tests
 - proto-lens-tests-dep

+extra-deps:
+  - text-2.0
+  - Cabal-3.6.3.0@sha256:ff97c442b0c679c1c9876acd15f73ac4f602b973c45bde42b43ec28265ee48f4,12459
+  - parsec-3.1.15.0@sha256:a162d4cc8884014ba35192545cad293af0529fe11497aad8834bbaaa3dfffc26,4429
+
 ghc-options:
   "$locals": -Wall -Werror
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinwoo jinwoo jinwoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blackgnezdo @brandon-leapyear @jinwoo