Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest internal version #180

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Update to the latest internal version #180

merged 8 commits into from
Jan 16, 2025

Conversation

s-kanev
Copy link
Contributor

@s-kanev s-kanev commented Jan 15, 2025

No description provided.

Googler and others added 8 commits January 15, 2025 12:57
PiperOrigin-RevId: 684574518
… size of the event payload.

Any remaining bytes are event IDs. But if the declared payload size is smaller,
subtracting these unsigned values when computing the number of IDs yields a very
large number, which subsequently leads to a memory allocation failure.

PiperOrigin-RevId: 688313672
… AMD ZEN4.

Further slice the L3 hits to local, near, and far L3.

PiperOrigin-RevId: 689060853
Code that we import via MODULE.bazel generates warnings that
are not really actionable from this projects' perspective.
Use new bazel6+ feature to set different options for files matching a
regex, in this case all external/ files shall have switched-off warnings.

Also: explicitly give the -xc++ option for c++ files. Bazel does
not invoke `clang++` but the generic `clang` driver for all files and
hopes that it auto-detects the file. This is not true for all
clang installations, and in particular clangd, clang-tidy etc. have
issues not knowing the type of file.
PiperOrigin-RevId: 693428479
Becuase of some (very) legacy perf behavior, quipper could ignore the number of PMU mappings and continue reading past them.
Remove that, since perf has been writing the number of mappings reliably since 4.14. This way, we can safely ignore checking against the PERF_RECORD_FEATURE size.
And that allows us to handle padding at the end of the event.

PiperOrigin-RevId: 713351371
Fuzzer test was showing an out-of-bounds accesss on a repeated field somewhere in `ReadNonHeaderEventDataWithoutHeader`. Staring at the code found this one.

PiperOrigin-RevId: 713486488
Copy link

google-cla bot commented Jan 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@s-kanev s-kanev requested a review from gmarin13 January 15, 2025 21:19
@s-kanev s-kanev merged commit 4071bb9 into master Jan 16, 2025
3 checks passed
@s-kanev s-kanev deleted the copybara_staging branch January 16, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants