Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github Actions] Configure a workflow for running unit tests and static code analysis #2671

Merged
merged 15 commits into from
Aug 23, 2024

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Aug 19, 2024

Towards #2670

Things done:

  • Triggers a github action on every pull request on master or push to master
  • Runs unit tests and static code analysis checks
  • Also enables gradle caching

@gino-m PTAL?

@shobhitagarwal1612 shobhitagarwal1612 changed the title Create a config for running unit tests using github actions [Github Actions] Configure a workflow for running unit tests on PRs and pushes to master Aug 19, 2024
@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as ready for review August 19, 2024 19:21
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick! One comment.

.github/workflows/unit-test.yml Outdated Show resolved Hide resolved
@shobhitagarwal1612 shobhitagarwal1612 changed the title [Github Actions] Configure a workflow for running unit tests on PRs and pushes to master [Github Actions] Configure a workflow for running unit tests Aug 19, 2024
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming nits incoming!

.github/workflows/unit-test.yml Outdated Show resolved Hide resolved
.github/workflows/unit-test.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.19%. Comparing base (b3ccb90) to head (4ea0312).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2671   +/-   ##
=========================================
  Coverage     61.19%   61.19%           
  Complexity     1187     1187           
=========================================
  Files           262      262           
  Lines          6041     6041           
  Branches        826      826           
=========================================
  Hits           3697     3697           
  Misses         1882     1882           
  Partials        462      462           
Flag Coverage Δ
service 61.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@shobhitagarwal1612 shobhitagarwal1612 changed the title [Github Actions] Configure a workflow for running unit tests [Github Actions] Configure a workflow for running unit tests and static code analysis Aug 23, 2024
@shobhitagarwal1612
Copy link
Member Author

@gino-m Can you add the codecov token to project secrets? I don't have access to add it.

Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅 !!

@gino-m gino-m merged commit 0dd6c94 into master Aug 23, 2024
5 checks passed
@gino-m gino-m deleted the github-action-unit-tests branch August 23, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants