Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] Fix errors on sync due to multiple instances of singleton #2380

Merged
merged 8 commits into from
Mar 17, 2024

Conversation

gino-m
Copy link
Collaborator

@gino-m gino-m commented Mar 16, 2024

Singleton may have been created by two components. Simplifying creation of GroundFirestore will hopefully resolve this.

Fixes #2377

@gino-m
Copy link
Collaborator Author

gino-m commented Mar 16, 2024

@shobhitagarwal1612 I'm hopeful that removing the extra level of Singleton provider will resolve this, and that if not the error log will help point us in the right direction. Can we merge this for now while we try to get more debug info?

@shobhitagarwal1612 shobhitagarwal1612 merged commit 1a91d2a into master Mar 17, 2024
2 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the gino-m/2377/fix-firestore-injection branch March 17, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Survey sync] Sync fails silently
2 participants