Declare tasks programatically rather than declaratively #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a few benefits: * It allows us to dynamically choose task dependencies (so for example the Linux standalone package can depend on the native executable task when running on Linux). * Similar tasks can be defined programmatically. * Task names are decoupled from Dart function names, which in turn allows us to avoid manually namespacing the package in favor of encouraging it to be imported with a Dart namespace. * It works around google/grinder.dart#337 and google/grinder.dart#338.
srawlins
approved these changes
Jul 29, 2019
| } | ||
|
|
||
| /// Returns the architecture name for the given boolean. | ||
| String _arch(bool x64) => x64 ? "x64" : "ia32"; |
There was a problem hiding this comment.
binary extension might be another good helper here. os == 'windows' ? '.exe' : '' appears three times in this file, and all three are in string interpolations. :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a few benefits:
It allows us to dynamically choose task dependencies (so for example
the Linux standalone package can depend on the native executable
task when running on Linux).
Similar tasks can be defined programmatically.
Task names are decoupled from Dart function names, which in turn
allows us to avoid manually namespacing the package in favor of
encouraging it to be imported with a Dart namespace.
It works around Double-exported tasks aren't visible to grinder grinder.dart#337 and Tasks can't depend on re-assigned task names grinder.dart#338.