Add support for DLLs on Windows #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
The CMake recommendation for RUNTIME destination is the
binfolder, not lib. It occurs because it installs .dll files there and that folder will be integrated to the PATH environment.https://cmake.org/cmake/help/latest/command/install.html#signatures
Plus, to export symbols to a DLL, CMake offers CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS which does it automatic. So you do not need to add
__declspecin your code with macros.So, when passing
-DBUILD_SHARED_LIBS=ON, the cctz, when build in Windows with msvc, it should result in${CMAKE_INSTALL_PREFIX}/lib/cctz.liband${CMAKE_INSTALL_PREFIX}/bin/cctz.dll, where the .lib works like a glue to load the .dll