[fuchsia] Adds new tzdata dir, explains all dirs #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `/config/tzdata` as a canonical path in the Fuchsia component's namespace. This is from: https://fuchsia.dev/fuchsia-src/concepts/process/namespaces#typical_directory_structure Each directory prefix entry in the list of prefixes that Fuchsia looks for timezone data files is now explained with a comment.
devbww
reviewed
Oct 11, 2023
Comment on lines
+537
to
+546
| // The tzdata from `config-data`. | ||
| "/config/data/tzdata/", | ||
| // The tzdata bundled in the component's package. | ||
| "/pkg/data/tzdata/", | ||
| // General data storage. | ||
| "/data/tzdata/", | ||
| // The recommended path for routed-in tzdata files. | ||
| // See for details: | ||
| // https://fuchsia.dev/fuchsia-src/concepts/process/namespaces?hl=en#typical_directory_structure | ||
| "/config/tzdata/", |
There was a problem hiding this comment.
Just checking that these are indeed in "descending order of preference". Naively, it seems strange that "/config/data/tzdata/" and "/config/tzdata/" are on opposite ends of the spectrum.
There was a problem hiding this comment.
In a way yes, this is the correct ordering. /config/data/... is deprecated, and /data/tzdata may be present in some older components, and /pkg/data should probably take precedence over /config/tzdata if the owners so wants.
There was a problem hiding this comment.
From the way you describe things, it sounds like the ordering should be:
/pkg/data/tzdata//config/tzdata//config/data/tzdata//data/tzdata
But, it's your choice.
devbww
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
/config/tzdataas a canonical path in theFuchsia component's namespace.
This is from:
https://fuchsia.dev/fuchsia-src/concepts/process/namespaces#typical_directory_structure
Each directory prefix entry in the list of prefixes that Fuchsia looks for timezone data files is now
explained with a comment.