Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quick fix of placeholder/key #67

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Fix quick fix of placeholder/key #67

merged 2 commits into from
Sep 27, 2024

Conversation

kzrnm
Copy link
Contributor

@kzrnm kzrnm commented Sep 26, 2024

Fixes #66

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@kzrnm kzrnm changed the title Fix quick fix of placeholder Fix quick fix of placeholder/key Sep 26, 2024
@mosuem
Copy link
Collaborator

mosuem commented Sep 26, 2024

You are having a run!

mosuem
mosuem approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@mosuem mosuem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry? Otherwise LGTM!

@mosuem mosuem merged commit 962ca41 into google:main Sep 27, 2024
4 checks passed
@kzrnm kzrnm deleted the fix/getMessage branch September 29, 2024 17:16
@kzrnm kzrnm mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosuem mosuem mosuem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quick fix completes undefined
2 participants
@kzrnm @mosuem