Overload FhirEngine.get() to Allow Fetching Multiple Resources by their IDs #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated versions of preview releases - Releases.kt - Publishing configurations of individual modules
- With unmerged PR google#1669 branch
- With unmerged PR google#1669 branch
- With unmerged PR google#1669 branch
- With unmerged PR google#1669 branch - With unmerged PR google#1893 branch
- With unmerged PR #1 - With unmerged PR google#1669 - With unmerged PR google#1927 - With unmerged PR google#1917
- With unmerged PR #1 - With unmerged PR google#1917
- With unmerged PR google#1973 - With unmerged PR #1 - With unmerged PR google#1917
- With unmerged PR #1 - With unmerged PR google#1917 - With unmerged PR google#1978 - With unmerged PR google#1964
- With unmerged PR #1 - With unmerged PR google#1917 - With unmerged PR google#1978 - With unmerged PR google#1964 - With unmerged PR google#1963 - With unmerged PR google#1907
- With unmerged PR #1 - With unmerged PR google#1917 - With unmerged PR google#1978 - With unmerged PR google#1964 - With unmerged PR google#1907
- With unmerged PR #1 - With unmerged PR google#1917 - With unmerged PR google#1978 - With unmerged PR google#1907 - With unmerged PR google#2016 - With unmerged PR google#2032
- With unmerged PR #1 - With unmerged PR google#1917 - With unmerged PR google#1978 - With unmerged PR google#1907 - With unmerged PR google#2016 - With unmerged PR google#2032 - With unmerged PR google#1669
- With unmerged PR #1 - With unmerged PR google#1917 - With unmerged PR google#1978 - With unmerged PR google#1907 - With unmerged PR google#2032 - With unmerged PR google#1669 - With unmerged PR google#2047
- With unmerged PR google#2032 - With unmerged PR #1 - With unmerged PR google#1669 - With unmerged PR google#2132 - With unmerged PR #9
FORK
- With unmerged PR #9
- WUP #13
SDK
- WUP google#2178
- WUP google#2650
- WUP google#2663
- WUP google#2645
FORK
- With unmerged PR #9
- WUP #13
SDK
- WUP google#2178
- WUP google#2650
- WUP google#2663
- WUP google#2645
- WUP google#2715
qiarie
force-pushed
the
2721-bypass-tokenindexentity-join-for-id
branch
from
fe98d19 to
6a693cf
Compare
qiarie
force-pushed
the
2721-bypass-tokenindexentity-join-for-id
branch
from
6a693cf to
89417fd
Compare
qiarie
force-pushed
the
2721-bypass-tokenindexentity-join-for-id
branch
from
cbfb3a9 to
68afe18
Compare
FORK
- With unmerged PR #9
- WUP #13
SDK
- WUP google#2178
- WUP google#2650
- WUP google#2645
…pass-tokenindexentity-join-for-id
jingtang10
reviewed
Dec 9, 2024
| * @throws ResourceNotFoundException if the resources are not found. | ||
| */ | ||
| @Throws(ResourceNotFoundException::class) | ||
| suspend fun get(type: ResourceType, vararg ids: String): List<Resource> |
There was a problem hiding this comment.
update the exception to say that if any resources are not found, this will throw.
There was a problem hiding this comment.
Does this mean if a request is made for 3 resources and only 2 are available it should throw an exception?
There was a problem hiding this comment.
Is there a scenario where getting all resources in the list is mandatory and returning a subset may break functionality?
jingtang10
reviewed
Dec 9, 2024
jingtang10
reviewed
Dec 9, 2024
| * @throws ResourceNotFoundException if the resources are not found. | ||
| */ | ||
| @Throws(ResourceNotFoundException::class) | ||
| suspend fun get(type: ResourceType, vararg ids: String): List<Resource> |
There was a problem hiding this comment.
i don't actually know how this really works with the original api.. it seems to me it'd be ambiguous to the compiler if the first or the second api is called when you're getting only 1 resource... can you verify this?
There was a problem hiding this comment.
The alternative would be to add a separate getResources API that accepts a resourceType and the list of IDs and returns a list of resources. This would cover the ambiguity.
What do you think of this approach?
…dexentity-join-for-id
- Add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2721
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.