Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Commit

Permalink
Merge pull request #204 from twitter-fabric/release-1.3.3
Browse files Browse the repository at this point in the history
1.3.3 release with fix for timer clearing
  • Loading branch information
fionawhim authored May 19, 2017
2 parents e5487c1 + a670a85 commit 19f4842
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
### v1.3.3 (2017-05-19):

Fixes incorrect timer clearing. (Thanks, @dmeiz1)

### v1.3.2 (2017-05-11):

Fix for calling clearTimeout in IE 8. (Thanks, @prchaoz!)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ details about why and how we built this.

See the [live demo](http://twitter-fabric.github.io/velocity-react/).

**Latest version:** v1.3.2 fixes IE8 bug introduced in v1.3 and removes React 0.14 from peer dependencies
**Latest version:** v1.3.3 fixes timer clearing bug on unmount of VelocityTransitionGroup

*Note: v1.1.0 and later require React 0.14.x*
*Note: v1.3.0 and later require React 15.3.x and should work with React 16*
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "velocity-react",
"version": "1.3.2",
"version": "1.3.3",
"description": "React components to wrap Velocity animations",
"main": "index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion src/velocity-transition-group.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class VelocityTransitionGroup extends React.Component {
});

_.forEach(this._scheduledAnimationRunFrames, function(frame) {
shimCancelAnimationFrame(timer);
shimCancelAnimationFrame(frame);
});

// We don't cancel all the in-process animations, so we use this to know if the component
Expand Down

0 comments on commit 19f4842

Please sign in to comment.