fix: updated golem-js to 3.4.2

golemfactory · Oct 17, 2024 · 1655ce0 · 1655ce0
1 parent d1e1c0c
commit 1655ce0
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 52 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -42,15 +42,15 @@
   },
   "homepage": "https://github.com/golemfactory/tesseract-ocr-golem#readme",
   "dependencies": {
-    "@golem-sdk/golem-js": "^3.4.1",
+    "@golem-sdk/golem-js": "^3.4.2",
     "debug": "^4.3.7",
     "generic-pool": "^3.9.0"
   },
   "devDependencies": {
     "@commitlint/cli": "^19.5.0",
     "@commitlint/config-conventional": "^19.5.0",
     "@types/debug": "^4.1.12",
-    "@types/node": "^20.16.11",
+    "@types/node": "^20.16.12",
     "@types/wtfnode": "^0.7.3",
     "@typescript-eslint/eslint-plugin": "^7.18.0",
     "@typescript-eslint/parser": "^7.18.0",

diff --git a/src/golem.ts b/src/golem.ts
@@ -315,22 +315,19 @@ export class Golem {
     dto: ProposalDTO,
     resources: ServiceDeploymentConfig["resources"],
   ) {
-    // FIXME: Remove after https://github.com/golemfactory/golem-js/pull/1111 is released
-    if (dto.cpuThreads) {
-      if (resources.minCpuThreads && resources.maxCpuThreads) {
-        return (
-          dto.cpuThreads >= resources.minCpuThreads &&
-          dto.cpuThreads <= resources.maxCpuThreads
-        );
-      }
+    if (resources.minCpuThreads && resources.maxCpuThreads) {
+      return (
+        dto.cpuThreads >= resources.minCpuThreads &&
+        dto.cpuThreads <= resources.maxCpuThreads
+      );
+    }
 
-      if (resources.maxCpuThreads) {
-        return dto.cpuThreads <= resources.maxCpuThreads;
-      }
+    if (resources.maxCpuThreads) {
+      return dto.cpuThreads <= resources.maxCpuThreads;
+    }
 
-      if (resources.minCpuThreads) {
-        return dto.cpuThreads >= resources.minCpuThreads;
-      }
+    if (resources.minCpuThreads) {
+      return dto.cpuThreads >= resources.minCpuThreads;
     }
   }