-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: use error wrap when possible #253
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 7527590) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/472695 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. |
Message from qiulaidongfeng: Patch Set 1: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. |
Message from Muhammad Shulhan: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. |
Message from qiulaidongfeng: Patch Set 1: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. |
Message from Muhammad Shulhan: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. |
Message from qiulaidongfeng: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-30T03:19:32Z","revision":"4bc09b6222500c2f0fc32e85567d285ef53bce06"} Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. |
Message from qiulaidongfeng: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/x_crypto-gotip-linux-amd64 has failed with summary (view all results): FAILURE
Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. |
I wanted to be able to use error.Is to match io or syscall errors on ssh network error.
This is currently not possible because errors are not wrapped.
This change replace
%v
verb with%w
in fmt.Errorf() calls.I was looking to fix this in
ssh
package but found that it could be extended to other package.This change should be transparent to existing code since they can still rely on old error comparison but will provide more details in case of check with
errors.Is
orerrors.As
.