-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssh: report disconnect messages as public error type from Conn.Wait #252
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: 2380e4d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/469875 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/469875. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/469875. |
Message from Maxime Tremblay: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/469875. |
Message from Maxime Tremblay: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/469875. |
Message from Nicola Murino: Patch Set 1: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/469875. |
Replaces internal and external use of
disconnectMsg
as an error type for reporting back disconnects with a new publicssh.DisconnectError
type.This makes it possible to extract the disconnect reason code programmatically, and respond appropriately.
See golang/go#39259 for suggestion to export disconnect error message type.
Related golang/go#37913 for sending disconnect messages.