Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

[WIP] "Orchestrator like" execution mode #138

Merged
merged 12 commits into from
Apr 25, 2018
Merged

[WIP] "Orchestrator like" execution mode #138

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c432d98
add dex parser dependency
tagantroy Apr 20, 2018
e5982da
implement parseTests function
tagantroy Apr 20, 2018
c5aae4a
specify return type and removed unused import
tagantroy Apr 21, 2018
b6f07b2
return List<String> instead of List<TestMethod> as a result of parseT…
tagantroy Apr 21, 2018
8a3b577
add parseTests test
tagantroy Apr 21, 2018
802dae4
Merge branch 'master' into feature/execute_tests_independently
tagantroy Apr 21, 2018
373684d
fix code style
tagantroy Apr 24, 2018
2906a3e
add TestMethod data class
tagantroy Apr 24, 2018
01c9f5e
change parseTests return try to List<TestMethod>
tagantroy Apr 24, 2018
1724c97
format TestMethod
tagantroy Apr 24, 2018
7ab8a92
remove extra lines
tagantroy Apr 24, 2018
8fb44a0
Merge branch 'master' into feature/execute_tests_independently
yunikkk Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer/src/main/kotlin/com/gojuno/composer/Apk.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import com.gojuno.commander.os.Notification
import com.gojuno.commander.os.process
import com.linkedin.dex.parser.DexParser
import com.linkedin.dex.parser.TestMethod
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks unused :)

import java.io.File

sealed class TestPackage {
data class Valid(val value: String) : TestPackage()
Expand Down Expand Up @@ -66,4 +65,5 @@ fun parseTestRunner(testApkPath: String): TestRunner =
.toBlocking()
.value()

fun parseTests(testApkPath: String) = DexParser.findTestMethods(testApkPath)
fun parseTests(testApkPath: String) : List<TestMethod> =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add an integration test (we already have some that parse runner from test apk, you can add couple tests there)

Not that I don't trust this library, but it can help catch future regressions!

DexParser.findTestMethods(testApkPath)