fix: Fixing Mergeable issue #11
reviewdog [errcheck] report
reported by reviewdog 🐶
Findings (0)
Filtered Findings (60)
server/core/runtime/policy/conftest_client_test.go|11 col 2| dot-imports: should not use dot imports (revive)
server/core/runtime/policy/conftest_client_test.go|19 col 2| dot-imports: should not use dot imports (revive)
server/core/runtime/common/common_test.go|9 col 2| dot-imports: should not use dot imports (revive)
server/events/vcs/bitbucketcloud/client.go|88 col 79| unused-parameter: parameter 'command' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/bitbucketcloud/client.go|109 col 42| unused-parameter: parameter 'repo' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/bitbucketcloud/client.go|141 col 77| unused-parameter: parameter 'vcsstatusname' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/bitbucketcloud/client.go|210 col 53| unused-parameter: parameter 'pullOptions' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/bitbucketcloud/client.go|237 col 33| unused-parameter: parameter 'repo' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/bitbucketcloud/client.go|266 col 38| unused-parameter: parameter 'repo' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/bitbucketcloud/client.go|277 col 33| unused-parameter: parameter 'pull' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/bitbucketcloud/client.go|281 col 30| unused-parameter: parameter 'VCSHostType' seems to be unused, consider removing or renaming it as _ (revive)
server/jobs/project_command_output_handler.go|270 col 41| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
server/jobs/project_command_output_handler.go|273 col 53| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
server/jobs/project_command_output_handler.go|276 col 45| unused-parameter: parameter 'jobID' seems to be unused, consider removing or renaming it as _ (revive)
server/jobs/project_command_output_handler.go|277 col 47| unused-parameter: parameter 'jobID' seems to be unused, consider removing or renaming it as _ (revive)
server/jobs/project_command_output_handler.go|282 col 44| unused-parameter: parameter 'pullInfo' seems to be unused, consider removing or renaming it as _ (revive)
server/jobs/project_command_output_handler.go|285 col 48| unused-parameter: parameter 'key' seems to be unused, consider removing or renaming it as _ (revive)
server/scheduled/executor_service_test.go|37 col 23| unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
server/jobs/project_command_output_handler_test.go|194 col 4| empty-block: this block is empty, you can remove it (revive)
server/jobs/project_command_output_handler_test.go|228 col 4| empty-block: this block is empty, you can remove it (revive)
server/jobs/project_command_output_handler_test.go|243 col 4| empty-block: this block is empty, you can remove it (revive)
server/core/locking/locking.go|169 col 66| unused-parameter: parameter 'pull' seems to be unused, consider removing or renaming it as _ (revive)
server/core/locking/locking.go|177 col 29| unused-parameter: parameter 'key' seems to be unused, consider removing or renaming it as _ (revive)
server/core/locking/locking.go|189 col 35| unused-parameter: parameter 'repoFullName' seems to be unused, consider removing or renaming it as _ (revive)
server/core/locking/locking.go|197 col 30| unused-parameter: parameter 'key' seems to be unused, consider removing or renaming it as _ (revive)
server/core/config/raw/global_cfg.go|201 col 25| unused-parameter: parameter 'value' seems to be unused, consider removing or renaming it as _ (revive)
server/core/config/raw/global_cfg.go|207 col 41| unused-parameter: parameter 'value' seems to be unused, consider removing or renaming it as _ (revive)
server/controllers/websocket/writer.go|15 col 30| unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
server/controllers/websocket/mux.go|38 col 14| unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
server/core/db/boltdb_test.go|289 col 2| redefines-builtin-id: redefinition of the built-in function new (revive)
server/core/db/boltdb_test.go|386 col 2| redefines-builtin-id: redefinition of the built-in function new (revive)
server/core/redis/redis_test.go|325 col 2| redefines-builtin-id: redefinition of the built-in function new (revive)
server/core/redis/redis.go|85 col 9| indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
server/core/redis/redis.go|106 col 9| indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
server/core/redis/redis.go|147 col 9| indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
server/core/redis/redis.go|59 col 42| unused-parameter: parameter 'bucket' seems to be unused, consider removing or renaming it as _ (revive)
server/events/webhooks/slack.go|44 col 29| unused-parameter: parameter 'log' seems to be unused, consider removing or renaming it as _ (revive)
server/core/runtime/cache/version_path_test.go|63 col 17| unused-parameter: parameter 'v' seems to be unused, consider removing or renaming it as _ (revive)
server/core/runtime/cache/version_path_test.go|89 col 17| unused-parameter: parameter 'v' seems to be unused, consider removing or renaming it as _ (revive)
server/core/runtime/version_step_runner.go|17 col 61| unused-parameter: parameter 'extraArgs' seems to be unused, consider removing or renaming it as _ (revive)
server/core/runtime/runtime.go|67 col 53| unused-parameter: parameter 'extraArgs' seems to be unused, consider removing or renaming it as _ (revive)
server/core/runtime/show_step_runner.go|30 col 58| unused-parameter: parameter 'extraArgs' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/bitbucketserver/client.go|136 col 79| unused-parameter: parameter 'command' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/bitbucketserver/client.go|205 col 77| unused-parameter: parameter 'vcsstatusname' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/bitbucketserver/client.go|361 col 33| unused-parameter: parameter 'pull' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/bitbucketserver/client.go|365 col 30| unused-parameter: parameter 'VCSHostType' seems to be unused, consider removing or renaming it as _ (revive)
server/core/runtime/apply_step_runner_test.go|364 col 43| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/gitlab_client_test.go|389 col 33| Error return value of (*encoding/json.Encoder).Encode
is not checked (errcheck)
server/events/vcs/gitlab_client_test.go|498 col 36| Error return value of (*encoding/json.Decoder).Decode
is not checked (errcheck)
server/events/markdown_renderer_test.go|567| File is not gofmt
-ed with -s
(gofmt)
server/events/vcs/azuredevops_client_test.go|621 col 13| G601: Implicit memory aliasing in for loop. (gosec)
server/events/vcs/azuredevops_client_test.go|622 col 13| G601: Implicit memory aliasing in for loop. (gosec)
server/events/event_parser_test.go|256 col 19| G601: Implicit memory aliasing in for loop. (gosec)
server/controllers/github_app_controller.go|88 col 58| unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/not_configured_vcs_client.go|73 col 46| unused-parameter: parameter 'VCSHostType' seems to be unused, consider removing or renaming it as _ (revive)
server/events/vcs/gitlab_client.go|173 col 85| unused-parameter: parameter 'command' seems to be unused, consider removing or renaming it as _ (revive)
server/events/plan_command_runner_test.go|499 col 9| type RepoModel
is unused (unused)
server/events/project_command_builder.go|714 col 32| SA4001: *&x will be simplified to x. It will not copy x. (staticcheck)
server/events/project_finder.go|227 col 18| SA1019: pm.Matches is deprecated: This implementation is buggy (it only checks a single parent dir against the pattern) and will be removed soon. Use either MatchesOrParentMatches or MatchesUsingParentResults instead. (staticcheck)
server/events/project_finder.go|269 col 17| SA1019: patternMatcher.Matches is deprecated: This implementation is buggy (it only checks a single parent dir against the pattern) and will be removed soon. Use either MatchesOrParentMatches or MatchesUsingParentResults instead. (staticcheck)