Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #21044 #21153

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Issue #21044 #21153

wants to merge 2 commits into from

Conversation

bupd
Copy link
Contributor

@bupd bupd commented Nov 8, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

This issue is not present in the LTS version of nodejs updating doc to use the correct node version.

  • added .nvmrc
  • updated docs to be clear for newcomers.

Issue being fixed

Fixes #21044

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@bupd bupd requested a review from a team as a code owner November 8, 2024 08:55
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.08%. Comparing base (c8c11b4) to head (b9f97eb).
Report is 327 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #21153       +/-   ##
===========================================
+ Coverage   45.36%   66.08%   +20.71%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114649   +101316     
  Branches     2719     2867      +148     
===========================================
+ Hits         6049    75766    +69717     
- Misses       6983    34739    +27756     
- Partials      301     4144     +3843     
Flag Coverage Δ
unittests 66.08% <ø> (+20.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1288 files with indirect coverage changes

@bupd bupd force-pushed the fix-ui-err branch 3 times, most recently from 55f922c to 61646a6 Compare November 8, 2024 14:38
@MinerYang
Copy link
Contributor

Please refer to #21044 (comment)

Signed-off-by: bupd <[email protected]>

update nvmrc to supported version

Signed-off-by: bupd <[email protected]>
@bupd
Copy link
Contributor Author

bupd commented Nov 15, 2024

@MinerYang update .nvmrc to the supported version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harbor UI Development: npm start Fails to Compile
5 participants