Skip to content

Commit

Permalink
Fixed comments
Browse files Browse the repository at this point in the history
- Remove duplicated test PodAnnotations
- Rename test ArtifactPullAsyncFlushDuration

Signed-off-by: Carlos Vega <[email protected]>
  • Loading branch information
cvegagimenez committed Aug 7, 2024
1 parent 1da7ed5 commit 74326ed
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 18 deletions.
4 changes: 2 additions & 2 deletions test/unittest/core_configmap_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ tests:
path: data.GC_TIME_WINDOW_HOURS
value: "2"

- it: GcTimeWindowHours
- it: ArtifactPullAsyncFlushDuration
set:
core:
artifactPullAsyncFlushDuration: 30
Expand Down Expand Up @@ -169,7 +169,7 @@ tests:
path: data.CACHE_EXPIRE_HOURS
value: "3"

- it: CuotaUpdate
- it: QuotaUpdate
set:
core:
quotaUpdateProvider: 3
Expand Down
11 changes: 0 additions & 11 deletions test/unittest/core_deployment_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,6 @@ tests:
path: spec.template.metadata.annotations["test.annotation"]
value: test-annotation

- it: PodAnnotations
set:
core:
podAnnotations:
test.annotation: test-annotation
template: templates/core/core-dpl.yaml
asserts:
- equal:
path: spec.template.metadata.annotations["test.annotation"]
value: test-annotation

- it: NoReplicas
set:
core:
Expand Down
2 changes: 1 addition & 1 deletion test/unittest/core_secret_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ tests:
- notExists:
path: data.HARBOR_ADMIN_PASSWORD

- it: ExistingDBSecret
- it: ExistingExternalDBSecret
set:
database:
external:
Expand Down
4 changes: 2 additions & 2 deletions test/unittest/core_svc_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ tests:
- notExists:
path: spec.type

- it: ExposeTLSEnabled
- it: InternalTLSEnabled
set:
internalTLS:
enabled: true
Expand All @@ -61,7 +61,7 @@ tests:
path: spec.ports[0].name
value: https-web

- it: ExposeTLSDisabled
- it: InternalTLSDisabled
set:
internalTLS:
enabled: false
Expand Down
2 changes: 0 additions & 2 deletions test/unittest/core_tls_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ tests:
set:
trivy:
enabled: false
registry:
enabled: false
internalTLS:
enabled: true
trustCa: testCa
Expand Down

0 comments on commit 74326ed

Please sign in to comment.