Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain that @export loads Resources when script instances are loaded #9903

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AdriaandeJongh
Copy link
Contributor

@AdriaandeJongh AdriaandeJongh commented Sep 4, 2024

I somehow couldn't find this anywhere in the docs even though this is very important and relevant info!

I also removed a very vague and illogical sentence that would have been just above or below my addition.

All feedback is welcome.

@AThousandShips AThousandShips requested a review from a team September 18, 2024 16:33
@AThousandShips AThousandShips added enhancement topic:gdscript area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Sep 18, 2024
Copy link
Member

@HolonProduction HolonProduction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding this makes the resource a dependency of the scene in which it is assigned to an export property, which means it will get loaded together with that scene.

The formulation from this PR seems a bit abstract to me, if this is what we want to convey. Or am I missing a second case which has nothing to do with scenes?

tutorials/scripting/gdscript/gdscript_exports.rst Outdated Show resolved Hide resolved
tutorials/scripting/gdscript/gdscript_exports.rst Outdated Show resolved Hide resolved
tutorials/scripting/gdscript/gdscript_exports.rst Outdated Show resolved Hide resolved
@AdriaandeJongh
Copy link
Contributor Author

AdriaandeJongh commented Sep 19, 2024

@HolonProduction I iterated on the wording based on your comments and made the whole thing a note. Also reverted removing the extremely vague line so that you or someone else can decide what to do with it. My opinion remains that it should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:gdscript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants