Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commas to sentence in using_tilemaps.rst #9871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lukas-Fletcher
Copy link
Contributor

@Lukas-Fletcher Lukas-Fletcher commented Aug 31, 2024

Will conflict with #9870. Could be changed to parentheses instead of commas.
I got confused when reading the sentence because "the layers you aren't currently editing from" all flow together but then what's left of sentence doesn't make sense "the same TileMap node will appear grayed out while in the TileMap editor". Hope the extra commas will help with the flow.
Another solution would be to rephrase it as "In the 2D editor, the layers from the same TileMap node that you aren't currently editing will appear grayed out while in the TileMap editor." or something along those lines.

@AThousandShips AThousandShips added enhancement discussion area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:2d labels Aug 31, 2024
@skyace65 skyace65 changed the title Add comments to sentence in using_tilemaps.rst Add commas to sentence in using_tilemaps.rst Sep 1, 2024
Copy link
Member

@Geometror Geometror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "In the 2D editor, the layers of a TileMap node you aren't currently editing will appear grayed out." ?
I've checked the behavior and the last part ("... in the TileMap editor") isn't actually the case (or I'm misunderstanding) so I think it can be removed, which makes the sentence even clearer.

@Lukas-Fletcher
Copy link
Contributor Author

@Geometror After some testing my understanding is also that it isn't actually the case. I agree that part probably should be removed. I don't know at what stage the transitioning from TileMap to TileMapLayer in the documentation is in but "In the 2D editor, the TileMapLayer nodes you aren't currently editing will appear grayed out." might be more fitting.

@skyace65
Copy link
Contributor

This needs to be updated since #9870 was merged

@skyace65 skyace65 added the needs work Needs additional work by the original author, someone else or in another repo. label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation discussion enhancement needs work Needs additional work by the original author, someone else or in another repo. topic:2d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants