Reorganize and improve shader Uniforms section #10261
Open
+167
−144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shader uniforms section has gotten very long and disordered, with bits of it seemingly split up by unrelated notes. This PR reorganizes it, adds subheaders, and makes some other minor improvements. The text itself is mostly unchanged.
The new order is:
Setting uniforms from code
)The only thing I'm unsure about is whether
Setting uniforms from code
should be the very first subheader, or where it is now. It makes sense to mention how to set uniforms from the inspector or from code early, BUT that section has a very long table so I think near the end is better. As a compromise, I linked to the section from the firstUniforms
section.