Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When ignoring UnknownGeometryType log the issue. #710

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

gdey
Copy link
Member

@gdey gdey commented Aug 10, 2020

We only support 2D geometries at current. When ignoring such geometries we will log that the geometry has been ignored, and give a useful workaround using ST_Force2D().

Fixes #449

We only support 2D geometries at current. When ignoring such geometries we will log that the geometry has been ignored, and give a useful work around using ST_Force2D().
@gdey gdey requested a review from ARolek as a code owner August 10, 2020 20:28
@coveralls
Copy link

Pull Request Test Coverage Report for Build baabd3be0-PR-710

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 45.24%

Totals Coverage Status
Change from base Build c197fe321: 0.03%
Covered Lines: 5298
Relevant Lines: 11711

💛 - Coveralls

Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ARolek ARolek merged commit 2f83b22 into v0.12.x Aug 10, 2020
@gdey gdey deleted the issue_449 branch April 6, 2021 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider/postgis: Drop Z dimension for 3D geometries
3 participants