Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canal: support ipv6 address #943

Merged
merged 5 commits into from
Nov 11, 2024
Merged

canal: support ipv6 address #943

merged 5 commits into from
Nov 11, 2024

Conversation

sinomoe
Copy link
Contributor

@sinomoe sinomoe commented Nov 8, 2024

canal:

  • address format support ipv6 with port like [::1]:3306 in canal
  • parse ipv6 address with optional port like ::1 or [::1]:3306 in dumper

dveeden
dveeden reviewed Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@dveeden dveeden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we try to support things like :3307 (e.g. only a port, not a host)? And maybe have a default port number if none is specified? (eg. ::1)

canal/canal.go Outdated Show resolved Hide resolved
canal/canal.go Outdated Show resolved Hide resolved
dveeden
dveeden reviewed Nov 8, 2024
View reviewed changes
canal/canal.go Outdated Show resolved Hide resolved
@dveeden
Copy link
Collaborator

dveeden commented Nov 8, 2024

What about tests and CI? Anything we can do to test this and/or make it easier to test?

@sinomoe
Copy link
Contributor Author

sinomoe commented Nov 8, 2024

Should we try to support things like :3307 (e.g. only a port, not a host)? And maybe have a default port number if none is specified? (eg. ::1)

As a client tool for MySQL, I think the host of the MySQL server should be clearly specified.

dveeden
dveeden reviewed Nov 8, 2024
View reviewed changes
mysql/const.go Outdated Show resolved Hide resolved
@sinomoe sinomoe marked this pull request as draft November 8, 2024 11:21
@sinomoe sinomoe force-pushed the feat/ipv6 branch 2 times, most recently from b9797d3 to 7c5a140 Compare November 8, 2024 12:05
@sinomoe sinomoe marked this pull request as ready for review November 8, 2024 12:07
@sinomoe
Copy link
Contributor Author

sinomoe commented Nov 8, 2024

What about tests and CI? Anything we can do to test this and/or make it easier to test?

Test cases and CI have been completed.

lance6716
lance6716 reviewed Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

dump/dumper.go Outdated Show resolved Hide resolved
lance6716
lance6716 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptal @dveeden

@lance6716 lance6716 merged commit 760b566 into go-mysql-org:master Nov 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@dveeden dveeden dveeden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinomoe @dveeden @lance6716