Code

Ensure ACKs are sent after backup#921

Code

Merged

lance6716 merged 7 commits intogo-mysql-org:mastergo-mysql-org/go-mysql:masterfrom dt8269:dterry/durablebinlogsdt8269/go-mysql:dterry/durablebinlogsCopy head branch name to clipboardOct 20, 2024

+276-86

Commits

Commits on Oct 7, 2024

• This commit addresses an issue where acknowledgments (ACKs) were sometimes sent to the master before binlog events were fully written and fsynced to disk during backup operations. Sending ACKs prem…

  Show description for c7a3c17
  

  Dylan Terry

  committed
  c7a3c17

  Copy full SHA for c7a3c17

Commits on Oct 9, 2024

• Refactor event handling by replacing SyncMode and EventHandleMode with SynchronousEventHandler. Simplify the event processing in BinlogSyncerConfig by introducing SynchronousEventHandler for synchr…

  Show description for d162219
  

  Dylan Terry

  committed
  d162219

  Copy full SHA for d162219

• Merge branch 'master' into dterry/durablebinlogs

  dt8269

  authored
  f04825e

  Copy full SHA for f04825e

• Add some comments and remember to remove SetEventHandler and the eventHandler attribute

  

  Dylan Terry

  committed
  ca576c9

  Copy full SHA for ca576c9

Commits on Oct 11, 2024

• Remove the timeout for synchronous backup, revert the timeout move to return the behavior to 30 days _between_ events, restore some comments, use struct instead of bool as recommended, add a note a…

  Show description for a8bcf4c
  

  Dylan Terry

  committed
  a8bcf4c

  Copy full SHA for a8bcf4c

Commits on Oct 13, 2024

• Make sure to assign the timeout on the syncer so the backup doesn't fail

  

  Dylan Terry

  committed
  06c9268

  Copy full SHA for 06c9268

Commits on Oct 16, 2024

• Make sure to add NewBackupHandler in order to expose the otherwise private handler outside the package

  

  Dylan Terry

  committed
  bc1dd07

  Copy full SHA for bc1dd07