Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recentupdate sorting bugs #32505

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Fix recentupdate sorting bugs #32505

merged 6 commits into from
Nov 15, 2024
+2 −0

Conversation

Zettat123
Copy link
Contributor

Fix #32499

  • Add the missing recentupdate to OrderByFlatMap
  • Assign default value(recentupdate) to EXPLORE_PAGING_DEFAULT_SORT

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 14, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 14, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 14, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 14, 2024
@lunny lunny enabled auto-merge (squash) November 14, 2024 23:13
@lunny lunny merged commit a0c0cb3 into go-gitea:main Nov 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 15, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Repository list not sorted
4 participants
@Zettat123 @lunny @silverwind @GiteaBot