Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edit team #32325

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fix edit team #32325

wants to merge 11 commits into from
+291 −103

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 23, 2024

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Oct 23, 2024
wxiaoguang
wxiaoguang reviewed Oct 23, 2024
View reviewed changes
services/org/team.go Outdated Show resolved Hide resolved
@lunny lunny marked this pull request as ready for review October 31, 2024 00:48
@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Oct 31, 2024
@lunny lunny marked this pull request as draft October 31, 2024 01:02
@lunny lunny marked this pull request as ready for review November 1, 2024 23:15
@yp05327
Copy link
Contributor

yp05327 commented Nov 5, 2024 •
edited
Loading

Any descriptions? And admin team should also have one?
For fix #32304?

Edited:
Will this PR replace #25691?

@yp05327
Copy link
Contributor

yp05327 commented Nov 5, 2024 •
edited
Loading

It seems that this is partly from https://codeberg.org/forgejo/forgejo/pulls/5529

And see:
#25670 (comment)
We forgot it.

@yp05327
Copy link
Contributor

yp05327 commented Nov 5, 2024 •
edited
Loading

I think you can merge these two PRs, for:

@yp05327 yp05327 self-requested a review November 5, 2024 01:40
@lunny lunny mentioned this pull request Nov 14, 2024
Open
@wxiaoguang wxiaoguang removed the backport/v1.22 This PR should be backported to Gitea 1.22 label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@yp05327 yp05327 Awaiting requested review from yp05327

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @yp05327 @wxiaoguang @GiteaBot