Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Makefile PROJECT names #598

Merged
merged 2 commits into from
Nov 19, 2022

Conversation

amintasvrp
Copy link

@amintasvrp amintasvrp commented Oct 18, 2022

This solution refers to which of the apps?

All OWASP Top 10 (2021) apps.

What changes were made ?

Changed the project name in the configuration files (MAKEFILE) of the OWASP Top 10 apps of 2021. In this sense, it consists of a contribution to solve the topic "Fix typo in deployments files(wrong owasp numeration)" of issue #561, and issue #587.

Did you test your changes? What commands did you run?

The Make command was executed, before and after the changes, to ensure that the compilation behavior was maintained.

@fguisso fguisso self-assigned this Oct 18, 2022
@fguisso
Copy link
Member

fguisso commented Oct 18, 2022

Awesome @amintasvrp thanks for your contribution.

@amintasvrp
Copy link
Author

Thank you, @fguisso !
Waiting for Globo Hacktoberfest approve.

image

@amintasvrp
Copy link
Author

amintasvrp commented Oct 26, 2022

@fguisso, Globo Hacktoberfest website is not recognizing approved PR. Was there a problem?
image

EDIT: There are 3 days left until the end of Hacktoberfest, and they still haven't counted the PR approval. Was there a problem?

Copy link
Contributor

@henriporto henriporto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job! 👍

@henriporto henriporto merged commit c213c61 into globocom:master Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants