Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kev/768_text_page_auto_copy #794

Merged
merged 3 commits into from
Jan 14, 2025
Merged

kev/768_text_page_auto_copy #794

merged 3 commits into from
Jan 14, 2025

Conversation

junhaow1
Copy link
Collaborator

@junhaow1 junhaow1 commented Jan 13, 2025

Pull Request Details

What issue does this PR address

Checklist

Complete the check-list below to ensure your branch is ready for PR.

Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html

  • Screenshots included in linked issue
  • Changes adhere to the style and coding guideline
  • No confidential information
  • No duplicated content
  • No lint check errors related to your changes (make prep or flutter analyze lib)
  • Pre-exisiting lint errors noted: [HERE]
  • Integration test make qtest.tmp screenshot included in issue
  • Tested on device:
    • Linux
    • MacOS
    • Windows
  • Added two reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the branch
  • Resolve any conflicts
  • Add one line summary into CHANGELOG.md
  • Bump appropriate version number in pubspec.yaml
  • Push to git repository and review
  • Merge PR into dev (gjwgit)

Copy link
Owner

@gjwgit gjwgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working for me on Linux. I'll have a further look.

@gjwgit gjwgit merged commit fe6010c into dev Jan 14, 2025
7 checks passed
@gjwgit gjwgit deleted the kev/768_text_page_auto_copy branch January 14, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants