Define package properties as defined as soon as package.init was called #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added improved TypeScript type definitions for package initialization to provide better type safety and developer experience. The changes include:
UninitializedPackage
andInitializedPackage
interfaces to represent package stateinit()
function type to use type assertion for post-initialization statepkg
global type to reflect initialization state@vixalien Last problem with this solution is, that this works for
imports.package [props]
but not forpgk[props]
, what do you think? Do you have any ideas how this could be done better? I could also create another import similar to@girs/gjs/doc
but for@girs/gjs/pkg-defined
.Related Issue
Fixes #220
Type of Change
Validation
Test Location:
examples/pkg-tsc/main.ts
Test Case:
Expected Behavior:
init()
call, TypeScript should recognize all package properties as definedChecklist