Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting in remote-input-element #35

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Update linting in remote-input-element #35

merged 5 commits into from
Apr 8, 2024

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Mar 29, 2024

Changes

  • Updated packages
    • eslint
    • eslint-plugin-github
  • Added packages
    • eslint-plugin-prettier
  • Changed lint NPM script to run eslint directly
  • Updated .eslintignore to include node_modules
  • Updated .eslintrc.json config
  • Prettier formatting changes

@TylerJDev TylerJDev marked this pull request as draft March 29, 2024 20:40
@TylerJDev TylerJDev self-assigned this Mar 29, 2024
@kendallgassner
Copy link
Contributor

@TylerJDev should we change this to "ready for review"?

@TylerJDev
Copy link
Contributor Author

@kendallgassner, I was thinking of waiting for your PR to be merged first, but I could switch my base to the main branch instead 🤔 I am not sure if it'll be overlapping as I think this one is based off of your branch originally.

@kendallgassner
Copy link
Contributor

Oh that makes sense! No problem, I am hoping to merge mine today.

Base automatically changed from kendallg/add-event-detail-eventType to main April 8, 2024 16:44
@TylerJDev TylerJDev marked this pull request as ready for review April 8, 2024 17:23
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@TylerJDev TylerJDev merged commit 84ff499 into main Apr 8, 2024
1 check passed
@TylerJDev TylerJDev deleted the update-lint branch April 8, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants