[view] px단위 rem으로 수정 #751
Merged
[view] px단위 rem으로 수정 #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcwadarong
previously approved these changes
Oct 4, 2024
xxxjinn
reviewed
Oct 4, 2024
packages/view/src/App.scss
Outdated
| } | ||
|
|
||
| .top-container { | ||
| height: 220px; | ||
| height: 13.75rem; | ||
| } | ||
|
|
||
| .middle-container { | ||
| display: flex; | ||
| height: calc(100vh - 200px); |
There was a problem hiding this comment.
네 발견못한 것 같아요..!! 이 부분 추가로 수정하겠습니다 ㅠㅠ
xxxjinn
reviewed
Oct 4, 2024
packages/view/src/utils/pxToRem.ts
Outdated
ytaek
previously approved these changes
Oct 6, 2024
shgusgh12
approved these changes
Oct 6, 2024
seungineer
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#732
Result
pxToRem함수를 구현해서 계산된 px을 rem으로 바꿔주었습니다.Work list
pxToRem함수를 만들어서 수정했습니다.Discussion